From: Christoph Hellwig <hch@infradead.org>
To: SurajSonawane2415 <surajsonawane0215@gmail.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Fix elevator_get_default() to check for null q->tag_set
Date: Sun, 6 Oct 2024 22:53:38 -0700 [thread overview]
Message-ID: <ZwN3YvV_j_s0ULhT@infradead.org> (raw)
In-Reply-To: <20241004123922.35834-1-surajsonawane0215@gmail.com>
> static struct elevator_type *elevator_get_default(struct request_queue *q)
> {
> - if (q->tag_set && q->tag_set->flags & BLK_MQ_F_NO_SCHED_BY_DEFAULT)
> - return NULL;
> + if (q->tag_set) {
q->tag_set can't be NULL for a blk-mq queue. So you can just remove
the q->tag_set check here and also in elv_support_iosched.
next prev parent reply other threads:[~2024-10-07 5:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 12:39 [PATCH] block: Fix elevator_get_default() to check for null q->tag_set SurajSonawane2415
2024-10-07 5:53 ` Christoph Hellwig [this message]
2024-10-07 11:14 ` [PATCH V2] " SurajSonawane2415
2024-10-07 20:24 ` Jens Axboe
2024-10-07 20:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwN3YvV_j_s0ULhT@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=surajsonawane0215@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox