From: Markus Elfring <Markus.Elfring@web.de>
To: Bart Van Assche <bvanassche@acm.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: blk-mq: Use seq_puts() in __blk_mq_debugfs_rq_show()
Date: Mon, 1 Jul 2019 22:00:21 +0200 [thread overview]
Message-ID: <5a8b6e93-72fb-1900-3338-662db7b8975d@web.de> (raw)
In-Reply-To: <e2a06dfd-4a03-2f56-59e6-abce261653d6@acm.org>
>> A string which did not contain a data format specification should be put
>> into a sequence. Thus use the corresponding function “seq_puts”.
>
> Why should this be done?
Do you prefer an other wording for the desired data output?
> Or in other words, what is wrong with the current code
> other than that it is slightly verbose and slightly slower than seq_puts()?
I suggest to improve such implementation details also at this place.
Regards,
Markus
prev parent reply other threads:[~2019-07-01 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 19:27 [PATCH] blk-mq: Use seq_puts() in __blk_mq_debugfs_rq_show() Markus Elfring
2019-07-01 19:47 ` Bart Van Assche
2019-07-01 20:00 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a8b6e93-72fb-1900-3338-662db7b8975d@web.de \
--to=markus.elfring@web.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox