Linux block layer
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Markus Elfring <Markus.Elfring@web.de>,
	linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] blk-mq: Use seq_puts() in __blk_mq_debugfs_rq_show()
Date: Mon, 1 Jul 2019 12:47:56 -0700	[thread overview]
Message-ID: <e2a06dfd-4a03-2f56-59e6-abce261653d6@acm.org> (raw)
In-Reply-To: <81847ca5-fac5-710c-29d5-f70b58f6437d@web.de>

On 7/1/19 12:27 PM, Markus Elfring wrote:
> A string which did not contain a data format specification should be put
> into a sequence. Thus use the corresponding function “seq_puts”.

"should"? Why should this be done? Or in other words, what is wrong with 
the current code other than that it is slightly verbose and slightly 
slower than seq_puts()? Do you think this matters for debugfs code?

Thanks,

Bart.

  reply	other threads:[~2019-07-01 19:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-01 19:27 [PATCH] blk-mq: Use seq_puts() in __blk_mq_debugfs_rq_show() Markus Elfring
2019-07-01 19:47 ` Bart Van Assche [this message]
2019-07-01 20:00   ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2a06dfd-4a03-2f56-59e6-abce261653d6@acm.org \
    --to=bvanassche@acm.org \
    --cc=Markus.Elfring@web.de \
    --cc=axboe@kernel.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox