Re: [PATCH blktests] io_uring user metadata offset test

[Chaitanya Kulkarni <chaitanyak@nvidia.com>]

On 11/7/25 15:18, Keith Busch wrote:
> diff --git a/tests/block/043 b/tests/block/043
> new file mode 100755
> index 0000000..0e6a6cb
> --- /dev/null
> +++ b/tests/block/043
> @@ -0,0 +1,27 @@
> +#!/bin/bash
> +
> +. tests/block/rc
> +
> +DESCRIPTION="Test userspace metadataoffsets"

nit:- DESCRIPTION="Test userspace metadata offsets" ? OR

"verify io_uring PI metadata integrity across buffer offsets" ?


> +QUICK=1
> +
> +device_requires() {
> +	_test_dev_has_metadata
> +	_test_dev_disables_extended_lba
> +}
> +
> +requires() {
> +	_have_kernel_option IO_URING

this requires a specific kernel version or higher for
IO_URING to have this metadata support ? OR any version
of kernel would work ?

> +	_have_kernel_option BLK_DEV_INTEGRITY

looking at blktests, we need something like :-

diff --git a/common/rc b/common/rc
index 86bb991..545da61 100644
--- a/common/rc
+++ b/common/rc
@@ -226,6 +226,12 @@ _have_kernel_option() {
         return 0
  }
  
+_have_kernel_options() {
+      for opt in "$@"; do
+          _have_kernel_option "$opt" || return 1
+      done
+}
+
  # Compare the version string in $1 in "a.b.c" format with "$2.$3.$4".
  # If "a.b.c" is smaller than "$2.$3.$4", return true. Otherwise, return
  # false.

not asking you to do anything, I'll send a patch and remove these
duplicates.


> +}
> +
> +test_device() {
> +	echo "Running ${TEST_NAME}"
> +
> +	if ! src/metadata ${TEST_DEV}; then
> +		echo "src/dio-offsets failed"

nit:- echo "src/metadata failed" ?

> +	fi
> +
> +	echo "Test complete"
> +}
> +
> diff --git a/tests/block/043.out b/tests/block/043.out
> new file mode 100644
> index 0000000..fda7fca
> --- /dev/null
> +++ b/tests/block/043.out
> @@ -0,0 +1,2 @@
> +Running block/043


-ck