public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: Keith Busch <kbusch@meta.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	hch <hch@lst.de>
Subject: Re: [PATCH blktests] io_uring user metadata offset test
Date: Wed, 19 Nov 2025 09:10:54 -0700	[thread overview]
Message-ID: <aR3sDqWvstDofSs7@kbusch-mbp> (raw)
In-Reply-To: <2gns47qyscyfz6bmcnfjmb5p5zgujpsxpsqwip46aktgfldizn@cqs5h6ugcvsx>

On Tue, Nov 11, 2025 at 07:58:30AM +0000, Shinichiro Kawasaki wrote:
> On Nov 07, 2025 / 15:18, Keith Busch wrote:
> > From: Keith Busch <kbusch@kernel.org>
> > 
> > For devices with metadata, tests various userspace offsets with
> > io_uring capabilities. If the metadata is formatted with ref tag
> > protection information, test various seed offsets as well.
> > 
> > Signed-off-by: Keith Busch <kbusch@kernel.org>
> 
> Keith, thanks for this patch. Looks important.
> 
> Just for curiousity, is there any condition to make this test case fail? I ran
> the test case with v6.18-rc5 kernel and QEMU NVME device (mi=8), then it
> passed. Do we need specific hardware to make it fail?
> 
>    If this test case just extends test coverage and no failure is expected at
>    this point, I think it is still useful.

It's not supposed to fail for any format. The test queries the
capabilities of the device and reacts accordingly. This test will send
various alignments and lengths that span page boundaries, and the kernel
will use it directly if the hardware supports that, or bounce it if not.

> This patch added the test case block/043, skipping block/042. You posted the
> patch for block/042 last month [1], and it is not yet settled on the blktests
> master branch. Do you have plan to respin it? If so, I think this block/043 can
> be applied before the block/042 patch get applied. Otherwise, I will try to find
> out my time to improve your block/042 patch and settle.

Yes, I'm working on a respin for 042 right now.

      reply	other threads:[~2025-11-19 16:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07 23:18 [PATCH blktests] io_uring user metadata offset test Keith Busch
2025-11-08  2:09 ` Chaitanya Kulkarni
2025-11-19 16:50   ` Keith Busch
2025-11-08  3:26 ` Chaitanya Kulkarni
2025-11-11  7:58 ` Shinichiro Kawasaki
2025-11-19 16:10   ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aR3sDqWvstDofSs7@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=hch@lst.de \
    --cc=kbusch@meta.com \
    --cc=linux-block@vger.kernel.org \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox