From: Kanchan Joshi <joshi.k@samsung.com>
To: Christoph Hellwig <hch@lst.de>
Cc: brauner@kernel.org, djwong@kernel.org, dgc@kernel.org,
jack@suse.cz, cem@kernel.org, axboe@kernel.dk, kbusch@kernel.org,
ritesh.list@gmail.com, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
gost.dev@samsung.com, Anuj Gupta <anuj20.g@samsung.com>
Subject: Re: [PATCH v4 4/6] xfs: generic AG set based steering
Date: Fri, 21 Aug 2026 17:38:43 +0530 [thread overview]
Message-ID: <5f212467-8920-4273-aa01-29d80d6e8f6a@samsung.com> (raw)
In-Reply-To: <20260819072137.GG1541@lst.de>
On 8/19/2026 12:51 PM, Christoph Hellwig wrote:
> On Fri, Jul 17, 2026 at 06:25:36PM +0530, Kanchan Joshi wrote:
>> Improve allocator concurrency and reduce interleaving by introducing
>> fixed sized AG set.
>> Use low bits of the inode as a hash to select AG within the AG set.
>> Overall, a file will try to use the same AG (and contiguity is maintained),
>> but multiple files will be spread across all AGs in the target AG set.
> I'm a bit worried this kind of magic - the inodes close to each other
> might not all have data or very different amounts of data.
>
> I suspect the root cause this helps with is that the XFS initial data
> placement algorithm that tries to place file data next to the inode is
> actively harmful these days. So doing an initial AG selection similar
> to how the RT device does the initial RTG selection might be more
> useful here (and thinking about moving to an inode32-like scheme
> where small metadata with a lot of churn is constrained to a few
> AGs).
Thinking to drop this for now, as this may need a distinct series.
This patch was here because stream based AG-set extended what this patch
was doing (i.e., the minimal fixed-size AG-set). That relationship goes
with the change you mentioned.
Replacing default AG allocator with an automatic RG-style rotor (no
user-supplied write-stream) might be a radical change in terms of impact.
next prev parent reply other threads:[~2026-08-21 12:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260717125624epcas5p3fefc5b8ff274260bf8fb2f1b225b4f9a@epcas5p3.samsung.com>
2026-07-17 12:55 ` [PATCH v4 0/6] xfs write streams Kanchan Joshi
2026-07-17 12:55 ` [PATCH v4 1/6] fs: add write-stream management ioctls Kanchan Joshi
2026-07-21 3:03 ` Darrick J. Wong
2026-07-30 14:52 ` Kanchan Joshi
2026-07-30 17:22 ` Darrick J. Wong
2026-07-31 8:15 ` Kanchan Joshi
2026-08-19 7:04 ` Christoph Hellwig
2026-08-19 22:05 ` Darrick J. Wong
2026-08-20 5:15 ` Miklos Szeredi
2026-08-19 7:08 ` Christoph Hellwig
2026-08-24 6:30 ` Kanchan Joshi
2026-08-19 7:11 ` Christoph Hellwig
2026-07-17 12:55 ` [PATCH v4 2/6] iomap: introduce and propagate write_stream Kanchan Joshi
2026-08-19 7:09 ` Christoph Hellwig
2026-07-17 12:55 ` [PATCH v4 3/6] xfs: implement write-stream management support Kanchan Joshi
2026-07-21 3:08 ` Darrick J. Wong
2026-07-31 8:03 ` Kanchan Joshi
2026-08-19 7:12 ` Christoph Hellwig
2026-08-19 7:18 ` Christoph Hellwig
2026-08-19 7:24 ` Christoph Hellwig
2026-08-21 11:39 ` Kanchan Joshi
2026-07-17 12:55 ` [PATCH v4 4/6] xfs: generic AG set based steering Kanchan Joshi
2026-07-21 3:20 ` Darrick J. Wong
2026-07-24 14:57 ` Kanchan Joshi
2026-08-19 7:21 ` Christoph Hellwig
2026-08-21 12:08 ` Kanchan Joshi [this message]
2026-07-17 12:55 ` [PATCH v4 5/6] xfs: write stream based AG placement Kanchan Joshi
2026-08-19 7:29 ` Christoph Hellwig
2026-08-21 12:33 ` Kanchan Joshi
2026-07-17 12:55 ` [PATCH v4 6/6] xfs: introduce software write streams Kanchan Joshi
2026-08-19 7:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f212467-8920-4273-aa01-29d80d6e8f6a@samsung.com \
--to=joshi.k@samsung.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=dgc@kernel.org \
--cc=djwong@kernel.org \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox