From: Daniel Wagner <dwagner@suse.de>
To: Costa Shulyupin <costa.shul@redhat.com>
Cc: ming.lei@redhat.com, "Jens Axboe" <axboe@kernel.dk>,
"Waiman Long" <longman@redhat.com>,
"Zefan Li" <lizefan.x@bytedance.com>, "Tejun Heo" <tj@kernel.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [RFC PATCH v1] blk-mq: isolate CPUs from hctx
Date: Tue, 12 Nov 2024 10:45:47 +0100 [thread overview]
Message-ID: <6604a1a1-e1cb-4d34-997e-de5a4263a68a@flourine.local> (raw)
In-Reply-To: <20241108054831.2094883-3-costa.shul@redhat.com>
On Fri, Nov 08, 2024 at 07:48:30AM +0200, Costa Shulyupin wrote:
> The housekeeping CPU masks, set up by the "isolcpus" and "nohz_full"
> boot command line options, are used at boot time to exclude selected
> CPUs from running some kernel housekeeping subsystems to minimize
> disturbance to latency sensitive userspace applications such as DPDK.
> This options can only be changed with a reboot. This is a problem for
> containerized workloads running on OpenShift/Kubernetes where a
> mix of low latency and "normal" workloads can be created/destroyed
> dynamically and the number of CPUs allocated to each workload is often
> not known at boot time.
>
> Cgroups allow configuring isolated_cpus at runtime.
> However, blk-mq may still use managed interrupts on the
> newly isolated CPUs.
>
> Rebuild hctx->cpumask considering isolated CPUs to avoid
> managed interrupts on those CPUs and reclaim non-isolated ones.
As far I understand this doesn't address the issue that the drivers
need also to be aware of isolcpu mask changes. That means even though
the cpumask is updated in the block layer, the driver doesn't know about
it and still runs on the isolated CPUs.
next prev parent reply other threads:[~2024-11-12 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 5:48 [RFC PATCH v1] blk-mq: isolate CPUs from hctx Costa Shulyupin
2024-11-12 9:45 ` Daniel Wagner [this message]
2024-11-15 15:45 ` Michal Koutný
2024-11-15 20:16 ` Waiman Long
2024-11-15 20:25 ` Costa Shulyupin
2024-11-15 21:37 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6604a1a1-e1cb-4d34-997e-de5a4263a68a@flourine.local \
--to=dwagner@suse.de \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=costa.shul@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=ming.lei@redhat.com \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox