From: Waiman Long <llong@redhat.com>
To: "Costa Shulyupin" <costa.shul@redhat.com>,
"Michal Koutný" <mkoutny@suse.com>
Cc: ming.lei@redhat.com, Jens Axboe <axboe@kernel.dk>,
Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, Daniel Wagner <dwagner@suse.de>
Subject: Re: [RFC PATCH v1] blk-mq: isolate CPUs from hctx
Date: Fri, 15 Nov 2024 16:37:00 -0500 [thread overview]
Message-ID: <67e8e089-4df2-4175-851a-4b49b964eca4@redhat.com> (raw)
In-Reply-To: <CADDUTFwYKjbPnzdzQA0ZjW4w3pHBsoZBQ6Ua5QbFp=X2-GfGtQ@mail.gmail.com>
On 11/15/24 3:25 PM, Costa Shulyupin wrote:
> Hello Michal.
>
> Isolation of CPUs from blk_mq_hw_ctx during boot is already handled on
> call hierarchy:
> ...
> nvme_probe()
> nvme_alloc_admin_tag_set()
> blk_mq_alloc_queue()
> blk_mq_init_allocated_queue()
> blk_mq_map_swqueue()
>
> blk_mq_map_swqueue() performs:
> for_each_cpu(cpu, hctx->cpumask) {
> if (cpu_is_isolated(cpu))
> cpumask_clear_cpu(cpu, hctx->cpumask);
> }
>
> static inline bool cpu_is_isolated(int cpu)
> {
> return !housekeeping_test_cpu(cpu, HK_TYPE_DOMAIN) ||
> !housekeeping_test_cpu(cpu, HK_TYPE_TICK) ||
> cpuset_cpu_is_isolated(cpu);
> }
cpuset_cpu_is_isolated() can be removed once the cpumasks can be changed
dynamically.
Cheers,
Longman
prev parent reply other threads:[~2024-11-15 21:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 5:48 [RFC PATCH v1] blk-mq: isolate CPUs from hctx Costa Shulyupin
2024-11-12 9:45 ` Daniel Wagner
2024-11-15 15:45 ` Michal Koutný
2024-11-15 20:16 ` Waiman Long
2024-11-15 20:25 ` Costa Shulyupin
2024-11-15 21:37 ` Waiman Long [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67e8e089-4df2-4175-851a-4b49b964eca4@redhat.com \
--to=llong@redhat.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=costa.shul@redhat.com \
--cc=dwagner@suse.de \
--cc=hannes@cmpxchg.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox