From: Jens Axboe <axboe@kernel.dk>
To: Phillip Potter <phil@philpotter.co.uk>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 1/1] cdrom: Add missing blank lines after declarations
Date: Mon, 16 Oct 2023 14:53:06 -0600 [thread overview]
Message-ID: <68a2a403-ab2c-4932-a12f-1751ff6ccd77@kernel.dk> (raw)
In-Reply-To: <20231016204741.1014-2-phil@philpotter.co.uk>
On 10/16/23 2:47 PM, Phillip Potter wrote:
> From: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
>
> Add missing blank lines after declarations to fix warning found by
> checkpatch.pl script.
Let's please not do this. It's fine to run checkpatch on new patches to
ensure that you don't make mistakes, but this is just useless churn.
Even worse:
> @@ -1202,6 +1204,7 @@ static int check_for_audio_disc(struct cdrom_device_info *cdi,
> {
> int ret;
> tracktype tracks;
> +
> cd_dbg(CD_OPEN, "entering check_for_audio_disc\n");
> if (!(cdi->options & CDO_CHECK_TYPE))
> return 0;
This int ret is using spaces and not a tab, why even make a newline
change and not sort that out too?
But it's all mostly moot as we should not be doing patches like this.
--
Jens Axboe
next prev parent reply other threads:[~2023-10-16 20:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 20:47 [PATCH 0/1] cdrom: cleanup patch for inclusion Phillip Potter
2023-10-16 20:47 ` [PATCH 1/1] cdrom: Add missing blank lines after declarations Phillip Potter
2023-10-16 20:53 ` Jens Axboe [this message]
2023-10-16 21:07 ` Phillip Potter
2023-10-16 21:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68a2a403-ab2c-4932-a12f-1751ff6ccd77@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox