Re: [PATCH 1/1] cdrom: Add missing blank lines after declarations

[Phillip Potter <phil@philpotter.co.uk>]

On Mon, Oct 16, 2023 at 02:53:06PM -0600, Jens Axboe wrote:
> On 10/16/23 2:47 PM, Phillip Potter wrote:
> > From: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
> > 
> > Add missing blank lines after declarations to fix warning found by
> > checkpatch.pl script.
> 
> Let's please not do this. It's fine to run checkpatch on new patches to
> ensure that you don't make mistakes, but this is just useless churn.
> Even worse:
> 
Hi Jens,

So to be clear, I should not accept patches that do cleanup like this
in future unless there are other substantive changes? I also build
tested the patch as per normal.

> > @@ -1202,6 +1204,7 @@ static int check_for_audio_disc(struct cdrom_device_info *cdi,
> >  {
> >          int ret;
> >  	tracktype tracks;
> > +
> >  	cd_dbg(CD_OPEN, "entering check_for_audio_disc\n");
> >  	if (!(cdi->options & CDO_CHECK_TYPE))
> >  		return 0;
> 
> This int ret is using spaces and not a tab, why even make a newline
> change and not sort that out too?
> 

Yes, good point. Given the patch only consisted of new lines though, I
didn't think it a bad one. If this is the policy though, I will be
stricter in future of course.

> But it's all mostly moot as we should not be doing patches like this.
> 
> -- 
> Jens Axboe
> 

Regards,
Phil