Linux block layer
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai1@huaweicloud.com>
To: Paolo VALENTE <paolo.valente@unimore.it>,
	Yu Kuai <yukuai1@huaweicloud.com>
Cc: Tejun Heo <tj@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Jan Kara <jack@suse.cz>,
	cgroups@vger.kernel.org,
	linux-block <linux-block@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	yi.zhang@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [patch v11 0/6] support concurrent sync io for bfq on a specail occasion
Date: Tue, 25 Oct 2022 15:31:07 +0800	[thread overview]
Message-ID: <69485939-d874-0201-e7ed-b3f49dbbb9c9@huaweicloud.com> (raw)
In-Reply-To: <A1E2F76F-2D27-4DCE-9B97-C8011CBE2A9E@unimore.it>

在 2022/10/25 14:34, Paolo VALENTE 写道:

>>
>> I rerun the manually test for 5 times, here is the average result:
>>
>> without this patchset / with this patchset:
>>
>> | --------------- | ------------- | ------------ | -------------- | ------------- | -------------- |
>> | cg1 weight      | 10            | 20           | 30             | 40          | 50             |
>> | cg2 weight      | 90            | 80           | 70             | 60          | 50             |
>> | cg1 bw MiB/s    | 21.4 / 21.74  | 42.72 / 46.6 | 63.82 / 61.52  | 94.74 / 90.92 | 140 / 138.2    |
>> | cg2 bw MiB/s    | 197.2 / 197.4 | 182 / 181.2  | 171.2 / 173.44 | 162 / 156.8   | 138.6 / 137.04 |
>> | cg2 bw / cg1 bw | 9.22 / 9.08   | 4.26 / 3.89  | 2.68 / 2.82    | 1.71 / 1.72   | 0.99 / 0.99    |
> 
> Great!  Results are (statistically) the same, with and without your
> patchset.  For me your patches are ok.  Thank you very much for this
> contribution, and sorry again for my delay.
> 
> Acked-by: Paolo Valente <paolo.valente@linaro.org>

Thanks for the review, it's nice to get this done finally!
> 
> Thanks,
> Paolo


  reply	other threads:[~2022-10-25  7:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-16  7:19 [patch v11 0/6] support concurrent sync io for bfq on a specail occasion Yu Kuai
2022-09-16  7:19 ` [patch v11 1/6] block, bfq: support to track if bfqq has pending requests Yu Kuai
2022-09-16  7:19 ` [patch v11 2/6] block, bfq: record how many queues have " Yu Kuai
2022-09-16  7:19 ` [patch v11 3/6] block, bfq: refactor the counting of 'num_groups_with_pending_reqs' Yu Kuai
2022-09-27 16:32   ` Paolo Valente
2022-09-27 16:33     ` Paolo VALENTE
2022-09-16  7:19 ` [patch v11 4/6] block, bfq: do not idle if only one group is activated Yu Kuai
2022-09-16  7:19 ` [patch v11 5/6] block, bfq: cleanup bfq_weights_tree add/remove apis Yu Kuai
2022-09-19  8:46   ` Jan Kara
2022-09-27 16:19     ` Paolo Valente
2022-09-16  7:19 ` [patch v11 6/6] block, bfq: cleanup __bfq_weights_tree_remove() Yu Kuai
2022-09-27 16:38 ` [patch v11 0/6] support concurrent sync io for bfq on a specail occasion Paolo Valente
2022-09-28  1:07   ` Yu Kuai
2022-10-11  8:11   ` Yu Kuai
2022-10-11  8:21     ` Paolo Valente
2022-10-11  9:36       ` Yu Kuai
2022-10-18  4:00         ` Yu Kuai
2022-10-25  6:34           ` Paolo VALENTE
2022-10-25  7:31             ` Yu Kuai [this message]
2022-11-01 11:32 ` Yu Kuai
2022-11-01 13:10 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69485939-d874-0201-e7ed-b3f49dbbb9c9@huaweicloud.com \
    --to=yukuai1@huaweicloud.com \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paolo.valente@unimore.it \
    --cc=tj@kernel.org \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox