From: Paolo Valente <paolo.valente@linaro.org>
To: Jan Kara <jack@suse.cz>
Cc: Yu Kuai <yukuai1@huaweicloud.com>,
tj@kernel.org, axboe@kernel.dk, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai3@huawei.com, yi.zhang@huawei.com
Subject: Re: [patch v11 5/6] block, bfq: cleanup bfq_weights_tree add/remove apis
Date: Tue, 27 Sep 2022 18:19:18 +0200 [thread overview]
Message-ID: <6E987AC9-9EBD-4172-A440-2FC13BA9AFD1@linaro.org> (raw)
In-Reply-To: <20220919084633.nmzastqkjool5jnc@quack3>
> Il giorno 19 set 2022, alle ore 10:46, Jan Kara <jack@suse.cz> ha scritto:
>
> On Fri 16-09-22 15:19:41, Yu Kuai wrote:
>> From: Yu Kuai <yukuai3@huawei.com>
>>
>> The 'bfq_data' and 'rb_root_cached' can both be accessed through
>> 'bfq_queue', thus only pass 'bfq_queue' as parameter.
>>
>> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
>
Thanks for keeping improving BFQ's code.
Acked-by: Paolo Valente <paolo.valente@linaro.org>
> Looks good. Feel free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> Honza
>> ---
>> block/bfq-iosched.c | 19 +++++++++----------
>> block/bfq-iosched.h | 10 +++-------
>> block/bfq-wf2q.c | 18 ++++++------------
>> 3 files changed, 18 insertions(+), 29 deletions(-)
>>
>> diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
>> index 6d95b0e488a8..4ad4fa0dad4a 100644
>> --- a/block/bfq-iosched.c
>> +++ b/block/bfq-iosched.c
>> @@ -870,9 +870,9 @@ static bool bfq_asymmetric_scenario(struct bfq_data *bfqd,
>> * In most scenarios, the rate at which nodes are created/destroyed
>> * should be low too.
>> */
>> -void bfq_weights_tree_add(struct bfq_data *bfqd, struct bfq_queue *bfqq,
>> - struct rb_root_cached *root)
>> +void bfq_weights_tree_add(struct bfq_queue *bfqq)
>> {
>> + struct rb_root_cached *root = &bfqq->bfqd->queue_weights_tree;
>> struct bfq_entity *entity = &bfqq->entity;
>> struct rb_node **new = &(root->rb_root.rb_node), *parent = NULL;
>> bool leftmost = true;
>> @@ -944,13 +944,14 @@ void bfq_weights_tree_add(struct bfq_data *bfqd, struct bfq_queue *bfqq,
>> * See the comments to the function bfq_weights_tree_add() for considerations
>> * about overhead.
>> */
>> -void __bfq_weights_tree_remove(struct bfq_data *bfqd,
>> - struct bfq_queue *bfqq,
>> - struct rb_root_cached *root)
>> +void __bfq_weights_tree_remove(struct bfq_queue *bfqq)
>> {
>> + struct rb_root_cached *root;
>> +
>> if (!bfqq->weight_counter)
>> return;
>>
>> + root = &bfqq->bfqd->queue_weights_tree;
>> bfqq->weight_counter->num_active--;
>> if (bfqq->weight_counter->num_active > 0)
>> goto reset_entity_pointer;
>> @@ -967,11 +968,9 @@ void __bfq_weights_tree_remove(struct bfq_data *bfqd,
>> * Invoke __bfq_weights_tree_remove on bfqq and decrement the number
>> * of active groups for each queue's inactive parent entity.
>> */
>> -void bfq_weights_tree_remove(struct bfq_data *bfqd,
>> - struct bfq_queue *bfqq)
>> +void bfq_weights_tree_remove(struct bfq_queue *bfqq)
>> {
>> - __bfq_weights_tree_remove(bfqd, bfqq,
>> - &bfqd->queue_weights_tree);
>> + __bfq_weights_tree_remove(bfqq);
>> }
>>
>> /*
>> @@ -6220,7 +6219,7 @@ static void bfq_completed_request(struct bfq_queue *bfqq, struct bfq_data *bfqd)
>> bfqq->budget_timeout = jiffies;
>>
>> bfq_del_bfqq_in_groups_with_pending_reqs(bfqq);
>> - bfq_weights_tree_remove(bfqd, bfqq);
>> + bfq_weights_tree_remove(bfqq);
>> }
>>
>> now_ns = ktime_get_ns();
>> diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
>> index 257acb54c6dc..4bb58ab0c90a 100644
>> --- a/block/bfq-iosched.h
>> +++ b/block/bfq-iosched.h
>> @@ -973,13 +973,9 @@ struct bfq_queue *bic_to_bfqq(struct bfq_io_cq *bic, bool is_sync);
>> void bic_set_bfqq(struct bfq_io_cq *bic, struct bfq_queue *bfqq, bool is_sync);
>> struct bfq_data *bic_to_bfqd(struct bfq_io_cq *bic);
>> void bfq_pos_tree_add_move(struct bfq_data *bfqd, struct bfq_queue *bfqq);
>> -void bfq_weights_tree_add(struct bfq_data *bfqd, struct bfq_queue *bfqq,
>> - struct rb_root_cached *root);
>> -void __bfq_weights_tree_remove(struct bfq_data *bfqd,
>> - struct bfq_queue *bfqq,
>> - struct rb_root_cached *root);
>> -void bfq_weights_tree_remove(struct bfq_data *bfqd,
>> - struct bfq_queue *bfqq);
>> +void bfq_weights_tree_add(struct bfq_queue *bfqq);
>> +void __bfq_weights_tree_remove(struct bfq_queue *bfqq);
>> +void bfq_weights_tree_remove(struct bfq_queue *bfqq);
>> void bfq_bfqq_expire(struct bfq_data *bfqd, struct bfq_queue *bfqq,
>> bool compensate, enum bfqq_expiration reason);
>> void bfq_put_queue(struct bfq_queue *bfqq);
>> diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c
>> index 5e8224c96921..124aaea6196e 100644
>> --- a/block/bfq-wf2q.c
>> +++ b/block/bfq-wf2q.c
>> @@ -707,7 +707,6 @@ __bfq_entity_update_weight_prio(struct bfq_service_tree *old_st,
>> struct bfq_queue *bfqq = bfq_entity_to_bfqq(entity);
>> unsigned int prev_weight, new_weight;
>> struct bfq_data *bfqd = NULL;
>> - struct rb_root_cached *root;
>> #ifdef CONFIG_BFQ_GROUP_IOSCHED
>> struct bfq_sched_data *sd;
>> struct bfq_group *bfqg;
>> @@ -770,19 +769,15 @@ __bfq_entity_update_weight_prio(struct bfq_service_tree *old_st,
>> * queue, remove the entity from its old weight counter (if
>> * there is a counter associated with the entity).
>> */
>> - if (prev_weight != new_weight && bfqq) {
>> - root = &bfqd->queue_weights_tree;
>> - __bfq_weights_tree_remove(bfqd, bfqq, root);
>> - }
>> + if (prev_weight != new_weight && bfqq)
>> + __bfq_weights_tree_remove(bfqq);
>> entity->weight = new_weight;
>> /*
>> * Add the entity, if it is not a weight-raised queue,
>> * to the counter associated with its new weight.
>> */
>> - if (prev_weight != new_weight && bfqq && bfqq->wr_coeff == 1) {
>> - /* If we get here, root has been initialized. */
>> - bfq_weights_tree_add(bfqd, bfqq, root);
>> - }
>> + if (prev_weight != new_weight && bfqq && bfqq->wr_coeff == 1)
>> + bfq_weights_tree_add(bfqq);
>>
>> new_st->wsum += entity->weight;
>>
>> @@ -1687,7 +1682,7 @@ void bfq_del_bfqq_busy(struct bfq_queue *bfqq, bool expiration)
>> * Next function is invoked last, because it causes bfqq to be
>> * freed. DO NOT use bfqq after the next function invocation.
>> */
>> - bfq_weights_tree_remove(bfqd, bfqq);
>> + bfq_weights_tree_remove(bfqq);
>> }
>> }
>>
>> @@ -1708,8 +1703,7 @@ void bfq_add_bfqq_busy(struct bfq_queue *bfqq)
>> if (!bfqq->dispatched) {
>> bfq_add_bfqq_in_groups_with_pending_reqs(bfqq);
>> if (bfqq->wr_coeff == 1)
>> - bfq_weights_tree_add(bfqd, bfqq,
>> - &bfqd->queue_weights_tree);
>> + bfq_weights_tree_add(bfqq);
>> }
>>
>> if (bfqq->wr_coeff > 1)
>> --
>> 2.31.1
>>
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
next prev parent reply other threads:[~2022-09-27 16:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 7:19 [patch v11 0/6] support concurrent sync io for bfq on a specail occasion Yu Kuai
2022-09-16 7:19 ` [patch v11 1/6] block, bfq: support to track if bfqq has pending requests Yu Kuai
2022-09-16 7:19 ` [patch v11 2/6] block, bfq: record how many queues have " Yu Kuai
2022-09-16 7:19 ` [patch v11 3/6] block, bfq: refactor the counting of 'num_groups_with_pending_reqs' Yu Kuai
2022-09-27 16:32 ` Paolo Valente
2022-09-27 16:33 ` Paolo VALENTE
2022-09-16 7:19 ` [patch v11 4/6] block, bfq: do not idle if only one group is activated Yu Kuai
2022-09-16 7:19 ` [patch v11 5/6] block, bfq: cleanup bfq_weights_tree add/remove apis Yu Kuai
2022-09-19 8:46 ` Jan Kara
2022-09-27 16:19 ` Paolo Valente [this message]
2022-09-16 7:19 ` [patch v11 6/6] block, bfq: cleanup __bfq_weights_tree_remove() Yu Kuai
2022-09-27 16:38 ` [patch v11 0/6] support concurrent sync io for bfq on a specail occasion Paolo Valente
2022-09-28 1:07 ` Yu Kuai
2022-10-11 8:11 ` Yu Kuai
2022-10-11 8:21 ` Paolo Valente
2022-10-11 9:36 ` Yu Kuai
2022-10-18 4:00 ` Yu Kuai
2022-10-25 6:34 ` Paolo VALENTE
2022-10-25 7:31 ` Yu Kuai
2022-11-01 11:32 ` Yu Kuai
2022-11-01 13:10 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6E987AC9-9EBD-4172-A440-2FC13BA9AFD1@linaro.org \
--to=paolo.valente@linaro.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox