* [PATCH] block: Fix a source code comment in include/uapi/linux/blkzoned.h
@ 2023-07-06 20:14 Bart Van Assche
2023-07-06 23:41 ` Damien Le Moal
2023-07-25 2:12 ` Jens Axboe
0 siblings, 2 replies; 4+ messages in thread
From: Bart Van Assche @ 2023-07-06 20:14 UTC (permalink / raw)
To: Jens Axboe
Cc: linux-block, Christoph Hellwig, Bart Van Assche, Hannes Reinecke,
Damien Le Moal, Shaun Tancheff, Damien Le Moal,
Martin K. Petersen
Fix the symbolic names for zone conditions in the blkzoned.h header
file.
Cc: Hannes Reinecke <hare@suse.de>
Cc: Damien Le Moal <dlemoal@kernel.org>
Fixes: 6a0cb1bc106f ("block: Implement support for zoned block devices")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
include/uapi/linux/blkzoned.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/uapi/linux/blkzoned.h b/include/uapi/linux/blkzoned.h
index b80fcc9ea525..f85743ef6e7d 100644
--- a/include/uapi/linux/blkzoned.h
+++ b/include/uapi/linux/blkzoned.h
@@ -51,13 +51,13 @@ enum blk_zone_type {
*
* The Zone Condition state machine in the ZBC/ZAC standards maps the above
* deinitions as:
- * - ZC1: Empty | BLK_ZONE_EMPTY
+ * - ZC1: Empty | BLK_ZONE_COND_EMPTY
* - ZC2: Implicit Open | BLK_ZONE_COND_IMP_OPEN
* - ZC3: Explicit Open | BLK_ZONE_COND_EXP_OPEN
- * - ZC4: Closed | BLK_ZONE_CLOSED
- * - ZC5: Full | BLK_ZONE_FULL
- * - ZC6: Read Only | BLK_ZONE_READONLY
- * - ZC7: Offline | BLK_ZONE_OFFLINE
+ * - ZC4: Closed | BLK_ZONE_COND_CLOSED
+ * - ZC5: Full | BLK_ZONE_COND_FULL
+ * - ZC6: Read Only | BLK_ZONE_COND_READONLY
+ * - ZC7: Offline | BLK_ZONE_COND_OFFLINE
*
* Conditions 0x5 to 0xC are reserved by the current ZBC/ZAC spec and should
* be considered invalid.
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] block: Fix a source code comment in include/uapi/linux/blkzoned.h
2023-07-06 20:14 [PATCH] block: Fix a source code comment in include/uapi/linux/blkzoned.h Bart Van Assche
@ 2023-07-06 23:41 ` Damien Le Moal
2023-07-24 20:35 ` Bart Van Assche
2023-07-25 2:12 ` Jens Axboe
1 sibling, 1 reply; 4+ messages in thread
From: Damien Le Moal @ 2023-07-06 23:41 UTC (permalink / raw)
To: Bart Van Assche, Jens Axboe
Cc: linux-block, Christoph Hellwig, Hannes Reinecke, Shaun Tancheff,
Damien Le Moal, Martin K. Petersen
On 7/7/23 05:14, Bart Van Assche wrote:
> Fix the symbolic names for zone conditions in the blkzoned.h header
> file.
>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Damien Le Moal <dlemoal@kernel.org>
> Fixes: 6a0cb1bc106f ("block: Implement support for zoned block devices")
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Looks good.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] block: Fix a source code comment in include/uapi/linux/blkzoned.h
2023-07-06 23:41 ` Damien Le Moal
@ 2023-07-24 20:35 ` Bart Van Assche
0 siblings, 0 replies; 4+ messages in thread
From: Bart Van Assche @ 2023-07-24 20:35 UTC (permalink / raw)
To: Damien Le Moal, Jens Axboe
Cc: linux-block, Christoph Hellwig, Hannes Reinecke, Shaun Tancheff,
Damien Le Moal, Martin K. Petersen
On 7/6/23 16:41, Damien Le Moal wrote:
> On 7/7/23 05:14, Bart Van Assche wrote:
>> Fix the symbolic names for zone conditions in the blkzoned.h header
>> file.
>>
>> Cc: Hannes Reinecke <hare@suse.de>
>> Cc: Damien Le Moal <dlemoal@kernel.org>
>> Fixes: 6a0cb1bc106f ("block: Implement support for zoned block devices")
>> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
>
> Looks good.
>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Hi Jens,
Do you agree that this patch is ready to be merged?
Thank you,
Bart.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block: Fix a source code comment in include/uapi/linux/blkzoned.h
2023-07-06 20:14 [PATCH] block: Fix a source code comment in include/uapi/linux/blkzoned.h Bart Van Assche
2023-07-06 23:41 ` Damien Le Moal
@ 2023-07-25 2:12 ` Jens Axboe
1 sibling, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2023-07-25 2:12 UTC (permalink / raw)
To: Bart Van Assche
Cc: linux-block, Christoph Hellwig, Hannes Reinecke, Damien Le Moal,
Shaun Tancheff, Damien Le Moal, Martin K. Petersen
On Thu, 06 Jul 2023 13:14:12 -0700, Bart Van Assche wrote:
> Fix the symbolic names for zone conditions in the blkzoned.h header
> file.
>
>
Applied, thanks!
[1/1] block: Fix a source code comment in include/uapi/linux/blkzoned.h
commit: e0933b526fbfd937c4a8f4e35fcdd49f0e22d411
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-25 2:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-06 20:14 [PATCH] block: Fix a source code comment in include/uapi/linux/blkzoned.h Bart Van Assche
2023-07-06 23:41 ` Damien Le Moal
2023-07-24 20:35 ` Bart Van Assche
2023-07-25 2:12 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox