From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: move iostat check into blk_acount_io_start()
Date: Thu, 3 Oct 2024 07:19:40 -0600 [thread overview]
Message-ID: <80ddb9f2-af29-4489-8985-8ba9588e5891@kernel.dk> (raw)
In-Reply-To: <Zv6XkXyAQ4yiaJGE@infradead.org>
On 10/3/24 7:09 AM, Christoph Hellwig wrote:
>> static inline bool blk_do_io_stat(struct request *rq)
>> {
>> + return rq->rq_flags & RQF_IO_STAT;
>> }
>
> I'd kill this somewhat oddly named wrapper now that it is a single
> check.
Yeah I did ponder that, since there's just that one check left. Will
do a followup for that.
--
Jens Axboe
next prev parent reply other threads:[~2024-10-03 13:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 19:26 [PATCH] block: move iostat check into blk_acount_io_start() Jens Axboe
2024-10-02 19:40 ` Keith Busch
2024-10-03 8:44 ` Anuj gupta
2024-10-03 13:09 ` Christoph Hellwig
2024-10-03 13:19 ` Jens Axboe [this message]
2024-10-06 14:07 ` kernel test robot
2024-10-06 21:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80ddb9f2-af29-4489-8985-8ba9588e5891@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox