From: Keith Busch <kbusch@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: move iostat check into blk_acount_io_start()
Date: Wed, 2 Oct 2024 13:40:50 -0600 [thread overview]
Message-ID: <Zv2hwm7EGvXA8mu5@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <550fc8a0-3461-49ac-879e-32908870f007@kernel.dk>
On Wed, Oct 02, 2024 at 01:26:08PM -0600, Jens Axboe wrote:
> Rather than have blk_do_io_stat() check for both RQF_IO_STAT and whether
> the request is a passthrough requests every time, move both of those
> checks into blk_account_io_start(). Then blk_do_io_stat() can be reduced
> to just checking for RQF_IO_STAT.
Looks good.
Reviewed-by: Keith Busch <kbusch@kernel.org>
next prev parent reply other threads:[~2024-10-02 19:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 19:26 [PATCH] block: move iostat check into blk_acount_io_start() Jens Axboe
2024-10-02 19:40 ` Keith Busch [this message]
2024-10-03 8:44 ` Anuj gupta
2024-10-03 13:09 ` Christoph Hellwig
2024-10-03 13:19 ` Jens Axboe
2024-10-06 14:07 ` kernel test robot
2024-10-06 21:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv2hwm7EGvXA8mu5@kbusch-mbp.dhcp.thefacebook.com \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox