From: "jianchao.wang" <jianchao.w.wang@oracle.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@kernel.dk>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Bart Van Assche <bart.vanassche@wdc.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V2 1/5] block: introduce blk_quiesce_timeout() and blk_unquiesce_timeout()
Date: Wed, 2 May 2018 13:16:46 +0800 [thread overview]
Message-ID: <81dd6a4b-c27c-d39e-cccf-68a0ff3d1711@oracle.com> (raw)
In-Reply-To: <20180502033342.GD22363@ming.t460p>
Hi Ming
On 05/02/2018 11:33 AM, Ming Lei wrote:
> No, there isn't such race, the 'mod_timer' doesn't make a difference
> because 'q->timeout_off' will be visible in new work func after
> cancel_work_sync() returns. So even the timer is expired, work func
> still returns immediately.
Yes, you are right.
even if timer is setup , but the timeout work will return.
Thanks
Jianchao
next prev parent reply other threads:[~2018-05-02 5:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-29 15:41 [PATCH V2 0/5] nvme: pci: fix & improve timeout handling Ming Lei
2018-04-29 15:41 ` [PATCH V2 1/5] block: introduce blk_quiesce_timeout() and blk_unquiesce_timeout() Ming Lei
2018-05-02 2:23 ` jianchao.wang
2018-05-02 3:33 ` Ming Lei
2018-05-02 5:16 ` jianchao.wang [this message]
2018-04-29 15:41 ` [PATCH V2 2/5] nvme: pci: cover timeout for admin commands running in EH Ming Lei
2018-04-29 15:41 ` [PATCH V2 3/5] nvme: pci: only wait freezing if queue is frozen Ming Lei
2018-04-29 15:41 ` [PATCH V2 4/5] nvme: fix race between freeze queues and unfreeze queues Ming Lei
2018-04-29 15:41 ` [PATCH V2 5/5] nvme: pci: simplify timeout handling Ming Lei
2018-05-02 2:23 ` jianchao.wang
2018-05-02 4:54 ` Ming Lei
2018-05-02 5:12 ` jianchao.wang
2018-05-02 7:27 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81dd6a4b-c27c-d39e-cccf-68a0ff3d1711@oracle.com \
--to=jianchao.w.wang@oracle.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox