[PATCH 0/1] cdrom: patch for inclusion

[PATCH 0/1] cdrom: patch for inclusion

[Phillip Potter]

Hi Jens,

Please apply the following patch from Jeff Johnson, that adds a missing
MODULE_DESCRIPTION() invocation to drivers/cdrom/cdrom.c, to prevent a
build warning regarding its absence.

Many thanks in advance.

Regards,
Phil

Jeff Johnson (1):
  cdrom: Add missing MODULE_DESCRIPTION()

 drivers/cdrom/cdrom.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.45.1

[PATCH 1/1] cdrom: Add missing MODULE_DESCRIPTION()

[Phillip Potter]

From: Jeff Johnson <quic_jjohnson@quicinc.com>

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cdrom/cdrom.o

Add the missing MODULE_DESCRIPTION() macro invocation.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Link: https://lore.kernel.org/lkml/20240530-cdrom-v1-1-51579c5c240a@quicinc.com
Reviewed-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/lkml/ZluYQbvrJkRlhnJC@KernelVM
Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
---
 drivers/cdrom/cdrom.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
index 20c90ebb3a3f..b6ee9ae36653 100644
--- a/drivers/cdrom/cdrom.c
+++ b/drivers/cdrom/cdrom.c
@@ -3708,4 +3708,5 @@ static void __exit cdrom_exit(void)
 
 module_init(cdrom_init);
 module_exit(cdrom_exit);
+MODULE_DESCRIPTION("Uniform CD-ROM driver for Linux");
 MODULE_LICENSE("GPL");
-- 
2.45.1

Re: [PATCH 1/1] cdrom: Add missing MODULE_DESCRIPTION()

[Jens Axboe]

On 6/1/24 4:18 PM, Phillip Potter wrote:
> From: Jeff Johnson <quic_jjohnson@quicinc.com>
> 
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cdrom/cdrom.o
> 
> Add the missing MODULE_DESCRIPTION() macro invocation.

Applied, but change it to:

MODULE_DESCRIPTION("Uniform CD-ROM driver");

as there's really no reason to state that it's "for Linux", it's
a Linux driver after all.

-- 
Jens Axboe

Re: [PATCH 1/1] cdrom: Add missing MODULE_DESCRIPTION()

[Jens Axboe]

On Sat, 01 Jun 2024 23:18:16 +0100, Phillip Potter wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cdrom/cdrom.o
> 
> Add the missing MODULE_DESCRIPTION() macro invocation.
> 
> 

Applied, thanks!

[1/1] cdrom: Add missing MODULE_DESCRIPTION()
      commit: 85f86c5ede7697162c54744258908e657e456f57

Best regards,
-- 
Jens Axboe