From: Damien Le Moal <dlemoal@kernel.org>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 1/5] blk-mq: cleanup __blk_mq_sched_dispatch_requests
Date: Thu, 13 Apr 2023 15:23:47 +0900 [thread overview]
Message-ID: <85db9dd3-e170-d0c4-0f15-d5fd38ce1a13@kernel.org> (raw)
In-Reply-To: <20230413060651.694656-2-hch@lst.de>
On 4/13/23 15:06, Christoph Hellwig wrote:
> __blk_mq_sched_dispatch_requests currently has duplicated logic
> for the cases where requests are on the hctx dispatch list or not.
> Merge the two with a new need_dispatch variable and remove a few
> pointless local variables.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks OK to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
next prev parent reply other threads:[~2023-04-13 6:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 6:06 cleanup blk_mq_run_hw_queue v2 Christoph Hellwig
2023-04-13 6:06 ` [PATCH 1/5] blk-mq: cleanup __blk_mq_sched_dispatch_requests Christoph Hellwig
2023-04-13 6:23 ` Damien Le Moal [this message]
2023-04-13 12:55 ` Jens Axboe
2023-04-13 6:06 ` [PATCH 2/5] blk-mq: remove the blk_mq_hctx_stopped check in blk_mq_run_work_fn Christoph Hellwig
2023-04-13 6:24 ` Damien Le Moal
2023-04-13 6:06 ` [PATCH 3/5] blk-mq: move the blk_mq_hctx_stopped check in __blk_mq_delay_run_hw_queue Christoph Hellwig
2023-04-13 6:26 ` Damien Le Moal
2023-04-13 6:06 ` [PATCH 4/5] blk-mq: move the !async handling out of __blk_mq_delay_run_hw_queue Christoph Hellwig
2023-04-13 6:06 ` [PATCH 5/5] blk-mq: remove __blk_mq_run_hw_queue Christoph Hellwig
2023-04-13 6:27 ` Damien Le Moal
2023-04-13 13:11 ` cleanup blk_mq_run_hw_queue v2 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85db9dd3-e170-d0c4-0f15-d5fd38ce1a13@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox