Re: [PATCH 2/5] blk-mq: remove the blk_mq_hctx_stopped check in blk_mq_run_work_fn

[Damien Le Moal <dlemoal@kernel.org>]

On 4/13/23 15:06, Christoph Hellwig wrote:
> blk_mq_hctx_stopped is alredy checked in blk_mq_sched_dispatch_requests
> under blk_mq_run_dispatch_ops() protetion, so remove the duplicate check.

s/protetion/protection

> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

> ---
>  block/blk-mq.c | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
> 
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 52f8e0099c7f4b..5289a34e68b937 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -2430,15 +2430,8 @@ EXPORT_SYMBOL(blk_mq_start_stopped_hw_queues);
>  
>  static void blk_mq_run_work_fn(struct work_struct *work)
>  {
> -	struct blk_mq_hw_ctx *hctx;
> -
> -	hctx = container_of(work, struct blk_mq_hw_ctx, run_work.work);
> -
> -	/*
> -	 * If we are stopped, don't run the queue.
> -	 */
> -	if (blk_mq_hctx_stopped(hctx))
> -		return;
> +	struct blk_mq_hw_ctx *hctx =
> +		container_of(work, struct blk_mq_hw_ctx, run_work.work);
>  
>  	__blk_mq_run_hw_queue(hctx);
>  }