Re: [GIT PULL] New test and a fixup for blktests

[Jens Axboe <axboe@kernel.dk>]

On 06/26/2017 02:45 PM, Omar Sandoval wrote:
> On Wed, Jun 21, 2017 at 09:22:47AM -0600, Jens Axboe wrote:
>> Hi Omar,
>>
>> Two changes here:
>>
>> - block/006 wants to use the iops results, but it isn't using _fio_perf.
>> - Add block/010 to test for shared vs non-shared tags performance.
>>
>>
>>   https://github.com/axboe/blktests.git axboe
>>
>>
>> ----------------------------------------------------------------
>> Jens Axboe (2):
>>       block/006: use _fio_perf to get perf results
>>       block/010: add test case for shared/unshared tags
>>
>>  tests/block/006     |  4 +--
>>  tests/block/010     | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  tests/block/010.out |  2 ++
>>  3 files changed, 86 insertions(+), 2 deletions(-)
>>  create mode 100755 tests/block/010
>>  create mode 100644 tests/block/010.out
>>
>> -- 
>> Jens Axboe
>>
> 
> Thanks, Jens, applied the first one, but
> 
> [ 1876.142470] null_blk: unknown parameter 'shared_tags' ignored
> 
> Am I missing a patch?

Yes, the shared tags is a new feature, it's coming in 4.13. But I checked
and it doesn't abort the module load. So the test ends up just being the
same thing run twice, if shared_tags isn't available. I figured that
was good enough.

-- 
Jens Axboe