* [GIT PULL] New test and a fixup for blktests
@ 2017-06-21 15:22 Jens Axboe
2017-06-26 20:45 ` Omar Sandoval
0 siblings, 1 reply; 5+ messages in thread
From: Jens Axboe @ 2017-06-21 15:22 UTC (permalink / raw)
To: Omar Sandoval; +Cc: linux-block@vger.kernel.org
Hi Omar,
Two changes here:
- block/006 wants to use the iops results, but it isn't using _fio_perf.
- Add block/010 to test for shared vs non-shared tags performance.
https://github.com/axboe/blktests.git axboe
----------------------------------------------------------------
Jens Axboe (2):
block/006: use _fio_perf to get perf results
block/010: add test case for shared/unshared tags
tests/block/006 | 4 +--
tests/block/010 | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++++
tests/block/010.out | 2 ++
3 files changed, 86 insertions(+), 2 deletions(-)
create mode 100755 tests/block/010
create mode 100644 tests/block/010.out
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [GIT PULL] New test and a fixup for blktests
2017-06-21 15:22 [GIT PULL] New test and a fixup for blktests Jens Axboe
@ 2017-06-26 20:45 ` Omar Sandoval
2017-06-26 21:02 ` Jens Axboe
0 siblings, 1 reply; 5+ messages in thread
From: Omar Sandoval @ 2017-06-26 20:45 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block@vger.kernel.org
On Wed, Jun 21, 2017 at 09:22:47AM -0600, Jens Axboe wrote:
> Hi Omar,
>
> Two changes here:
>
> - block/006 wants to use the iops results, but it isn't using _fio_perf.
> - Add block/010 to test for shared vs non-shared tags performance.
>
>
> https://github.com/axboe/blktests.git axboe
>
>
> ----------------------------------------------------------------
> Jens Axboe (2):
> block/006: use _fio_perf to get perf results
> block/010: add test case for shared/unshared tags
>
> tests/block/006 | 4 +--
> tests/block/010 | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> tests/block/010.out | 2 ++
> 3 files changed, 86 insertions(+), 2 deletions(-)
> create mode 100755 tests/block/010
> create mode 100644 tests/block/010.out
>
> --
> Jens Axboe
>
Thanks, Jens, applied the first one, but
[ 1876.142470] null_blk: unknown parameter 'shared_tags' ignored
Am I missing a patch?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [GIT PULL] New test and a fixup for blktests
2017-06-26 20:45 ` Omar Sandoval
@ 2017-06-26 21:02 ` Jens Axboe
2017-06-26 21:04 ` Omar Sandoval
0 siblings, 1 reply; 5+ messages in thread
From: Jens Axboe @ 2017-06-26 21:02 UTC (permalink / raw)
To: Omar Sandoval; +Cc: linux-block@vger.kernel.org
On 06/26/2017 02:45 PM, Omar Sandoval wrote:
> On Wed, Jun 21, 2017 at 09:22:47AM -0600, Jens Axboe wrote:
>> Hi Omar,
>>
>> Two changes here:
>>
>> - block/006 wants to use the iops results, but it isn't using _fio_perf.
>> - Add block/010 to test for shared vs non-shared tags performance.
>>
>>
>> https://github.com/axboe/blktests.git axboe
>>
>>
>> ----------------------------------------------------------------
>> Jens Axboe (2):
>> block/006: use _fio_perf to get perf results
>> block/010: add test case for shared/unshared tags
>>
>> tests/block/006 | 4 +--
>> tests/block/010 | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>> tests/block/010.out | 2 ++
>> 3 files changed, 86 insertions(+), 2 deletions(-)
>> create mode 100755 tests/block/010
>> create mode 100644 tests/block/010.out
>>
>> --
>> Jens Axboe
>>
>
> Thanks, Jens, applied the first one, but
>
> [ 1876.142470] null_blk: unknown parameter 'shared_tags' ignored
>
> Am I missing a patch?
Yes, the shared tags is a new feature, it's coming in 4.13. But I checked
and it doesn't abort the module load. So the test ends up just being the
same thing run twice, if shared_tags isn't available. I figured that
was good enough.
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [GIT PULL] New test and a fixup for blktests
2017-06-26 21:02 ` Jens Axboe
@ 2017-06-26 21:04 ` Omar Sandoval
2017-06-26 21:05 ` Jens Axboe
0 siblings, 1 reply; 5+ messages in thread
From: Omar Sandoval @ 2017-06-26 21:04 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block@vger.kernel.org
On Mon, Jun 26, 2017 at 03:02:55PM -0600, Jens Axboe wrote:
> On 06/26/2017 02:45 PM, Omar Sandoval wrote:
> > On Wed, Jun 21, 2017 at 09:22:47AM -0600, Jens Axboe wrote:
> >> Hi Omar,
> >>
> >> Two changes here:
> >>
> >> - block/006 wants to use the iops results, but it isn't using _fio_perf.
> >> - Add block/010 to test for shared vs non-shared tags performance.
> >>
> >>
> >> https://github.com/axboe/blktests.git axboe
> >>
> >>
> >> ----------------------------------------------------------------
> >> Jens Axboe (2):
> >> block/006: use _fio_perf to get perf results
> >> block/010: add test case for shared/unshared tags
> >>
> >> tests/block/006 | 4 +--
> >> tests/block/010 | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >> tests/block/010.out | 2 ++
> >> 3 files changed, 86 insertions(+), 2 deletions(-)
> >> create mode 100755 tests/block/010
> >> create mode 100644 tests/block/010.out
> >>
> >> --
> >> Jens Axboe
> >>
> >
> > Thanks, Jens, applied the first one, but
> >
> > [ 1876.142470] null_blk: unknown parameter 'shared_tags' ignored
> >
> > Am I missing a patch?
>
> Yes, the shared tags is a new feature, it's coming in 4.13. But I checked
> and it doesn't abort the module load. So the test ends up just being the
> same thing run twice, if shared_tags isn't available. I figured that
> was good enough.
Sounds good, I'll apply it as-is and add an extra patch on top that
checks if the module parameter exists.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [GIT PULL] New test and a fixup for blktests
2017-06-26 21:04 ` Omar Sandoval
@ 2017-06-26 21:05 ` Jens Axboe
0 siblings, 0 replies; 5+ messages in thread
From: Jens Axboe @ 2017-06-26 21:05 UTC (permalink / raw)
To: Omar Sandoval; +Cc: linux-block@vger.kernel.org
On 06/26/2017 03:04 PM, Omar Sandoval wrote:
> On Mon, Jun 26, 2017 at 03:02:55PM -0600, Jens Axboe wrote:
>> On 06/26/2017 02:45 PM, Omar Sandoval wrote:
>>> On Wed, Jun 21, 2017 at 09:22:47AM -0600, Jens Axboe wrote:
>>>> Hi Omar,
>>>>
>>>> Two changes here:
>>>>
>>>> - block/006 wants to use the iops results, but it isn't using _fio_perf.
>>>> - Add block/010 to test for shared vs non-shared tags performance.
>>>>
>>>>
>>>> https://github.com/axboe/blktests.git axboe
>>>>
>>>>
>>>> ----------------------------------------------------------------
>>>> Jens Axboe (2):
>>>> block/006: use _fio_perf to get perf results
>>>> block/010: add test case for shared/unshared tags
>>>>
>>>> tests/block/006 | 4 +--
>>>> tests/block/010 | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>> tests/block/010.out | 2 ++
>>>> 3 files changed, 86 insertions(+), 2 deletions(-)
>>>> create mode 100755 tests/block/010
>>>> create mode 100644 tests/block/010.out
>>>>
>>>> --
>>>> Jens Axboe
>>>>
>>>
>>> Thanks, Jens, applied the first one, but
>>>
>>> [ 1876.142470] null_blk: unknown parameter 'shared_tags' ignored
>>>
>>> Am I missing a patch?
>>
>> Yes, the shared tags is a new feature, it's coming in 4.13. But I checked
>> and it doesn't abort the module load. So the test ends up just being the
>> same thing run twice, if shared_tags isn't available. I figured that
>> was good enough.
>
> Sounds good, I'll apply it as-is and add an extra patch on top that
> checks if the module parameter exists.
Awesome, extra cookie for you :-)
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-26 21:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-21 15:22 [GIT PULL] New test and a fixup for blktests Jens Axboe
2017-06-26 20:45 ` Omar Sandoval
2017-06-26 21:02 ` Jens Axboe
2017-06-26 21:04 ` Omar Sandoval
2017-06-26 21:05 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox