Linux block layer
 help / color / mirror / Atom feed
From: Jon Derrick <jonathan.derrick@intel.com>
To: David Binderman <dcb314@hotmail.com>,
	"scott.bauer@intel.com" <scott.bauer@intel.com>,
	"rafael.antognolli@intel.com" <rafael.antognolli@intel.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: block/sed-opal.c: 2 * bad if tests ?
Date: Mon, 6 Mar 2017 08:19:33 -0700	[thread overview]
Message-ID: <9b98f762-ca72-1f6a-6f28-d42138389df7@intel.com> (raw)
In-Reply-To: <DB5PR08MB096759FCAD880317DBA854FD9C2C0@DB5PR08MB0967.eurprd08.prod.outlook.com>

On 03/06/2017 05:00 AM, David Binderman wrote:
> Hello there,
> 
> 1.
> 
> block/sed-opal.c:2136:40: warning: logical �and� of mutually exclusive tests is always false [-Wlogical-op]
> 
> Source code is
> 
>     if (lk_unlk->session.who < OPAL_USER1 &&
>         lk_unlk->session.who > OPAL_USER9) {
> 
> 2.
> 
> block/sed-opal.c:2319:37: warning: logical �and� of mutually exclusive tests is always false [-Wlogical-op]
> 
>     if (opal_session->who < OPAL_USER1 &&
>         opal_session->who > OPAL_USER9) {
> 
> Duplicate.
> 
> Also in the same file:
> 
> [block/sed-opal.c:1034]: (style) Variable 'method' is assigned a value that is never used.
> 
> Regards
> 
> David Binderman
> 
Thanks for the catch(es). Will provide patch shortly

      reply	other threads:[~2017-03-06 15:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-06 12:00 block/sed-opal.c: 2 * bad if tests ? David Binderman
2017-03-06 15:19 ` Jon Derrick [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b98f762-ca72-1f6a-6f28-d42138389df7@intel.com \
    --to=jonathan.derrick@intel.com \
    --cc=axboe@kernel.dk \
    --cc=dcb314@hotmail.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael.antognolli@intel.com \
    --cc=scott.bauer@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox