* block/sed-opal.c: 2 * bad if tests ?
@ 2017-03-06 12:00 David Binderman
2017-03-06 15:19 ` Jon Derrick
0 siblings, 1 reply; 2+ messages in thread
From: David Binderman @ 2017-03-06 12:00 UTC (permalink / raw)
To: scott.bauer@intel.com, jonathan.derrick@intel.com,
rafael.antognolli@intel.com, axboe@kernel.dk,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Hello there,
1.
block/sed-opal.c:2136:40: warning: logical =91and=92 of mutually exclusive =
tests is always false [-Wlogical-op]
Source code is
if (lk_unlk->session.who < OPAL_USER1 &&
lk_unlk->session.who > OPAL_USER9) {
2.
block/sed-opal.c:2319:37: warning: logical =91and=92 of mutually exclusive =
tests is always false [-Wlogical-op]
if (opal_session->who < OPAL_USER1 &&
opal_session->who > OPAL_USER9) {
Duplicate.
Also in the same file:
[block/sed-opal.c:1034]: (style) Variable 'method' is assigned a value that=
is never used.
Regards
David Binderman
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: block/sed-opal.c: 2 * bad if tests ?
2017-03-06 12:00 block/sed-opal.c: 2 * bad if tests ? David Binderman
@ 2017-03-06 15:19 ` Jon Derrick
0 siblings, 0 replies; 2+ messages in thread
From: Jon Derrick @ 2017-03-06 15:19 UTC (permalink / raw)
To: David Binderman, scott.bauer@intel.com,
rafael.antognolli@intel.com, axboe@kernel.dk,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
On 03/06/2017 05:00 AM, David Binderman wrote:
> Hello there,
>
> 1.
>
> block/sed-opal.c:2136:40: warning: logical �and� of mutually exclusive tests is always false [-Wlogical-op]
>
> Source code is
>
> if (lk_unlk->session.who < OPAL_USER1 &&
> lk_unlk->session.who > OPAL_USER9) {
>
> 2.
>
> block/sed-opal.c:2319:37: warning: logical �and� of mutually exclusive tests is always false [-Wlogical-op]
>
> if (opal_session->who < OPAL_USER1 &&
> opal_session->who > OPAL_USER9) {
>
> Duplicate.
>
> Also in the same file:
>
> [block/sed-opal.c:1034]: (style) Variable 'method' is assigned a value that is never used.
>
> Regards
>
> David Binderman
>
Thanks for the catch(es). Will provide patch shortly
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-06 15:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-06 12:00 block/sed-opal.c: 2 * bad if tests ? David Binderman
2017-03-06 15:19 ` Jon Derrick
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox