Re: [PATCH blktests v5 1/4] nvme/rc: Add setter for attr_qid_max

[Chaitanya Kulkarni <chaitanyak@nvidia.com>]

On 4/5/23 08:46, Daniel Wagner wrote:
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
>   tests/nvme/rc | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/tests/nvme/rc b/tests/nvme/rc
> index a3c9b42d91e6..ec7678dbe09e 100644
> --- a/tests/nvme/rc
> +++ b/tests/nvme/rc
> @@ -617,6 +617,16 @@ _set_nvmet_dhgroup() {
>   	     "${cfs_path}/dhchap_dhgroup"
>   }
>   
> +_set_nvmet_attr_qid_max() {
> +	local nvmet_subsystem="$1"
> +	local qid_max="$2"
> +	local cfs_path="${NVMET_CFS}/subsystems/${nvmet_subsystem}"
> +
> +	if [[ -f "${cfs_path}/attr_qid_max" ]]; then
> +		echo $qid_max > "${cfs_path}/attr_qid_max"
> +	fi
> +}
> +
>

this is only used in the testcase patch #4, until we get a second
user move it to patch #4 ?

in case this was already discussed and decision made to keep it
in rc, please ignore this comment.

-ck