From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>,
James Smart <jsmart2021@gmail.com>
Subject: Re: [PATCH blktests v5 1/4] nvme/rc: Add setter for attr_qid_max
Date: Thu, 6 Apr 2023 07:05:45 +0000 [thread overview]
Message-ID: <f83b0c8a-3716-5154-9c5c-3989bcf2d320@nvidia.com> (raw)
In-Reply-To: <2w3ki4ntl5m2farwokvepbgtcvd5piywv3cmdyzp4s6su6fngc@55wsvekrge3c>
On 4/5/23 23:12, Daniel Wagner wrote:
> On Wed, Apr 05, 2023 at 06:39:43PM +0000, Chaitanya Kulkarni wrote:
>> this is only used in the testcase patch #4, until we get a second
>> user move it to patch #4 ?
>>
>> in case this was already discussed and decision made to keep it
>> in rc, please ignore this comment.
> There wasn't any decision on this topic. I was not sure if I should put it in rc
> but I saw there are already _set_nvmet_*() functions. Thus I came to the
> conclusion it makes maintaining these helper function simpler in future because
> they are all in one file. If someone touches all _set_nvmet_*() function this
> one is not forgotten.
>
> The same goes for the other rc helpers (patch 1-3).
>
> That said, I really do not insit in putiting in rc.
if there are functions in rc which are only testcase specific let's keep
those there, we can always do cleanup later ..
-ck
next prev parent reply other threads:[~2023-04-06 7:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 15:46 [PATCH blktests v5 0/4] test queue count changes on reconnect Daniel Wagner
2023-04-05 15:46 ` [PATCH blktests v5 1/4] nvme/rc: Add setter for attr_qid_max Daniel Wagner
2023-04-05 18:39 ` Chaitanya Kulkarni
2023-04-06 6:12 ` Daniel Wagner
2023-04-06 7:05 ` Chaitanya Kulkarni [this message]
2023-04-06 7:32 ` Daniel Wagner
2023-04-05 15:46 ` [PATCH blktests v5 2/4] nvme/rc: Add nvmet attribute feature detection function Daniel Wagner
2023-04-05 15:46 ` [PATCH blktests v5 3/4] nvme/rc: Add helper to wait for nvme ctrl state Daniel Wagner
2023-04-05 18:43 ` Chaitanya Kulkarni
2023-04-05 15:46 ` [PATCH blktests v5 4/4] nvme/048: test queue count changes on reconnect Daniel Wagner
2023-04-05 18:44 ` Chaitanya Kulkarni
2023-04-05 18:57 ` Chaitanya Kulkarni
2023-04-06 6:17 ` Daniel Wagner
2023-04-06 7:04 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f83b0c8a-3716-5154-9c5c-3989bcf2d320@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=jsmart2021@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox