Linux block layer
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Hannes Reinecke <hare@suse.de>, Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 09/13] block: always treat offline and read-only zones as dead
Date: Fri, 7 Aug 2026 08:48:11 -0700	[thread overview]
Message-ID: <9ffd0912-8373-4d6e-9eaa-7fff63160b45@kernel.org> (raw)
In-Reply-To: <d6b95a4a-6cbc-46ac-8e7e-12ef8588447c@suse.de>

On 2026/08/07 3:46, Hannes Reinecke wrote:
> On 8/6/26 6:04 PM, Damien Le Moal wrote:
>> Since any write BIO targeting an offline or a read-only zone will fail,
>> there is no point in keeping zone write plugs for these zones.
>> So for any offline or read-only zone, the zone write plug should always
>> be treated as dead.
>>
>> Do this by modifying disk_check_zone_wplug_dead() to always mark read-only
>> and offline zones as dead to force a removal of the zone write plug from
>> the disk hash table on BIO submission. blk_zone_wplug_prepare_bio() is
>> also modified to have the same checks to immediately fail a write BIO
>> targeting a read-only or offline zone. With these two changes, any newly
>> issued or unplugged write BIO targeting a read-only or offline zone is
>> immediately failed.
>>
>> Finally, disk_zone_wplug_sync_state() is modified to add a call to
>> disk_mark_zone_wplug_dead() for the zone write plug of any read-only or
>> offline zone found during zone revalidation or a report zones.
>>
>> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
>> ---
>>   block/blk-zoned.c | 113 +++++++++++++++++++++++++---------------------
>>   1 file changed, 61 insertions(+), 52 deletions(-)
>>
> Makes one feeling sorry for filesystems having to deal with this ..

Yeah. If you depop a head under a mounted FS, the FS will not be happy :)

For file systems that can support it (e.g. XFS with metadata & log on a
different device), the plan is to execute depop going through the file system,
so that the FS can synchronize itself with zones going offline so that it does
not uselessly trip on IO errors and also can notify the user of affected files.


-- 
Damien Le Moal
Western Digital Research

  reply	other threads:[~2026-08-07 15:48 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06 16:04 [PATCH v2 00/13] Improve handling of offline and read-only zones Damien Le Moal
2026-08-06 16:04 ` [PATCH v2 01/13] block: remove disk_free_zone_resources() Damien Le Moal
2026-08-10 14:46   ` Christoph Hellwig
2026-08-06 16:04 ` [PATCH v2 02/13] block: refactor disk_revalidate_zone_resources() Damien Le Moal
2026-08-10 14:47   ` Christoph Hellwig
2026-08-06 16:04 ` [PATCH v2 03/13] block: refactor disk_update_zone_resources() Damien Le Moal
2026-08-07  9:03   ` Hannes Reinecke
2026-08-10 14:48   ` Christoph Hellwig
2026-08-06 16:04 ` [PATCH v2 04/13] block: remember a zone type regardless of its condition Damien Le Moal
2026-08-07  9:11   ` Hannes Reinecke
2026-08-10 14:52   ` Christoph Hellwig
2026-08-06 16:04 ` [PATCH v2 05/13] block: refactor bdev_zone_is_seq() Damien Le Moal
2026-08-07  9:12   ` Hannes Reinecke
2026-08-06 16:04 ` [PATCH v2 06/13] block: introduce disk_for_all_zone_wplugs() Damien Le Moal
2026-08-07 10:20   ` Hannes Reinecke
2026-08-06 16:04 ` [PATCH v2 07/13] block: drop all zone write plugs on capacity changes Damien Le Moal
2026-08-07 10:24   ` Hannes Reinecke
2026-08-06 16:04 ` [PATCH v2 08/13] block: propagate readonly and offline conditions to zone write plugs Damien Le Moal
2026-08-07 10:32   ` Hannes Reinecke
2026-08-06 16:04 ` [PATCH v2 09/13] block: always treat offline and read-only zones as dead Damien Le Moal
2026-08-07 10:46   ` Hannes Reinecke
2026-08-07 15:48     ` Damien Le Moal [this message]
2026-08-06 16:04 ` [PATCH v2 10/13] block: fail zone management operations to read-only and offline zones Damien Le Moal
2026-08-07 11:42   ` Hannes Reinecke
2026-08-06 16:04 ` [PATCH v2 11/13] block: allow read-only and offline conventional zones Damien Le Moal
2026-08-07 11:48   ` Hannes Reinecke
2026-08-06 16:04 ` [PATCH v2 12/13] block: simplify disk_zone_set_cond() Damien Le Moal
2026-08-07 11:51   ` Hannes Reinecke
2026-08-06 16:04 ` [PATCH v2 13/13] block: flag zoned disks with GENHD_FL_NO_PART Damien Le Moal
2026-08-07 11:53   ` Hannes Reinecke
2026-08-07 15:34 ` [PATCH v2 00/13] Improve handling of offline and read-only zones Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ffd0912-8373-4d6e-9eaa-7fff63160b45@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox