From: Dan Carpenter <error27@gmail.com>
To: hch@lst.de
Cc: linux-block@vger.kernel.org
Subject: [bug report] blk-cgroup: simplify blkg freeing from initialization failure paths
Date: Wed, 8 Feb 2023 17:15:05 +0300 [thread overview]
Message-ID: <Y+OuadIcbqX4n6tG@kili> (raw)
Hello Christoph Hellwig,
The patch 27b642b07a4a: "blk-cgroup: simplify blkg freeing from
initialization failure paths" from Feb 3, 2023, leads to the
following Smatch static checker warning:
block/blk-cgroup.c:762 blkg_conf_prep() warn: sleeping in atomic context
block/blk-cgroup.c:769 blkg_conf_prep() warn: sleeping in atomic context
blkg_conf_prep()
[ takes a lock and calls blkg_free() in the same function. ]
block/blk-cgroup.c:387 blkg_create() warn: sleeping in atomic context
blkg_lookup_create() <- disables preempt
blkg_conf_prep() <- disables preempt
blkcg_init_disk() <- disables preempt
-> blkg_create()
[ The first call tree is a false positive but blkg_conf_prep()
and blkcg_init_disk() have issues. ]
regards,
dan carpenter
reply other threads:[~2023-02-08 14:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+OuadIcbqX4n6tG@kili \
--to=error27@gmail.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox