* [bug report] blk-cgroup: simplify blkg freeing from initialization failure paths
@ 2023-02-08 14:15 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2023-02-08 14:15 UTC (permalink / raw)
To: hch; +Cc: linux-block
Hello Christoph Hellwig,
The patch 27b642b07a4a: "blk-cgroup: simplify blkg freeing from
initialization failure paths" from Feb 3, 2023, leads to the
following Smatch static checker warning:
block/blk-cgroup.c:762 blkg_conf_prep() warn: sleeping in atomic context
block/blk-cgroup.c:769 blkg_conf_prep() warn: sleeping in atomic context
blkg_conf_prep()
[ takes a lock and calls blkg_free() in the same function. ]
block/blk-cgroup.c:387 blkg_create() warn: sleeping in atomic context
blkg_lookup_create() <- disables preempt
blkg_conf_prep() <- disables preempt
blkcg_init_disk() <- disables preempt
-> blkg_create()
[ The first call tree is a false positive but blkg_conf_prep()
and blkcg_init_disk() have issues. ]
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-02-08 14:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-08 14:15 [bug report] blk-cgroup: simplify blkg freeing from initialization failure paths Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox