* [PATCH V2] blk-mq: kill warning when building block/blk-mq-debugfs-zoned.c
@ 2022-03-02 0:34 Ming Lei
2022-03-02 1:48 ` Chaitanya Kulkarni
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ming Lei @ 2022-03-02 0:34 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block, Ming Lei, Christoph Hellwig, kernel test robot
Fix the following warning when building block/blk-mq-debugfs-zoned.c:
In file included from block/blk-mq-debugfs-zoned.c:7:
block/blk-mq-debugfs.h:24:14: warning: ‘struct blk_mq_hw_ctx’ declared inside parameter list will not be visible outside of this definition or declaration
24 | struct blk_mq_hw_ctx *hctx);
| ^~~~~~~~~~~~~
Cc: Christoph Hellwig <hch@lst.de>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
V2:
- forward declaration of struct blk_mq_hw_ctx instead of including
header, as suggested by Christoph
block/blk-mq-debugfs.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/blk-mq-debugfs.h b/block/blk-mq-debugfs.h
index a68aa6041a10..361d759c6fad 100644
--- a/block/blk-mq-debugfs.h
+++ b/block/blk-mq-debugfs.h
@@ -2,6 +2,8 @@
#ifndef INT_BLK_MQ_DEBUGFS_H
#define INT_BLK_MQ_DEBUGFS_H
+struct blk_mq_hw_ctx;
+
#ifdef CONFIG_BLK_DEBUG_FS
#include <linux/seq_file.h>
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH V2] blk-mq: kill warning when building block/blk-mq-debugfs-zoned.c
2022-03-02 0:34 [PATCH V2] blk-mq: kill warning when building block/blk-mq-debugfs-zoned.c Ming Lei
@ 2022-03-02 1:48 ` Chaitanya Kulkarni
2022-03-02 8:04 ` Christoph Hellwig
2022-03-09 1:06 ` Ming Lei
2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2022-03-02 1:48 UTC (permalink / raw)
To: Ming Lei
Cc: linux-block@vger.kernel.org, Jens Axboe, Christoph Hellwig,
kernel test robot
On 3/1/22 4:34 PM, Ming Lei wrote:
> Fix the following warning when building block/blk-mq-debugfs-zoned.c:
>
> In file included from block/blk-mq-debugfs-zoned.c:7:
> block/blk-mq-debugfs.h:24:14: warning: ‘struct blk_mq_hw_ctx’ declared inside parameter list will not be visible outside of this definition or declaration
> 24 | struct blk_mq_hw_ctx *hctx);
> | ^~~~~~~~~~~~~
>
> Cc: Christoph Hellwig <hch@lst.de>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2] blk-mq: kill warning when building block/blk-mq-debugfs-zoned.c
2022-03-02 0:34 [PATCH V2] blk-mq: kill warning when building block/blk-mq-debugfs-zoned.c Ming Lei
2022-03-02 1:48 ` Chaitanya Kulkarni
@ 2022-03-02 8:04 ` Christoph Hellwig
2022-03-09 1:06 ` Ming Lei
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2022-03-02 8:04 UTC (permalink / raw)
To: Ming Lei; +Cc: Jens Axboe, linux-block, kernel test robot
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2] blk-mq: kill warning when building block/blk-mq-debugfs-zoned.c
2022-03-02 0:34 [PATCH V2] blk-mq: kill warning when building block/blk-mq-debugfs-zoned.c Ming Lei
2022-03-02 1:48 ` Chaitanya Kulkarni
2022-03-02 8:04 ` Christoph Hellwig
@ 2022-03-09 1:06 ` Ming Lei
2 siblings, 0 replies; 4+ messages in thread
From: Ming Lei @ 2022-03-09 1:06 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block, Christoph Hellwig, kernel test robot
On Wed, Mar 02, 2022 at 08:34:31AM +0800, Ming Lei wrote:
> Fix the following warning when building block/blk-mq-debugfs-zoned.c:
>
> In file included from block/blk-mq-debugfs-zoned.c:7:
> block/blk-mq-debugfs.h:24:14: warning: ‘struct blk_mq_hw_ctx’ declared inside parameter list will not be visible outside of this definition or declaration
> 24 | struct blk_mq_hw_ctx *hctx);
> | ^~~~~~~~~~~~~
>
> Cc: Christoph Hellwig <hch@lst.de>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> V2:
> - forward declaration of struct blk_mq_hw_ctx instead of including
> header, as suggested by Christoph
Hello Jens,
This patch looks missed, can you take a look?
Thanks,
Ming
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-09 1:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-02 0:34 [PATCH V2] blk-mq: kill warning when building block/blk-mq-debugfs-zoned.c Ming Lei
2022-03-02 1:48 ` Chaitanya Kulkarni
2022-03-02 8:04 ` Christoph Hellwig
2022-03-09 1:06 ` Ming Lei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox