From: Christoph Hellwig <hch@infradead.org>
To: cgel.zte@gmail.com
Cc: axboe@kernel.dk, viro@zeniv.linux.org.uk, hannes@cmpxchg.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org,
Yang Yang <yang.yang29@zte.com.cn>,
Ran Xiaokai <ran.xiaokai@zte.com.cn>
Subject: Re: [PATCH] block/psi: make PSI annotations of submit_bio only work for file pages
Date: Wed, 16 Mar 2022 01:48:05 -0700 [thread overview]
Message-ID: <YjGkRT+ccoZ0ZNDq@infradead.org> (raw)
In-Reply-To: <20220316063927.2128383-1-yang.yang29@zte.com.cn>
> @@ -1035,8 +1035,9 @@ void __bio_add_page(struct bio *bio, struct page *page,
> bio->bi_iter.bi_size += len;
> bio->bi_vcnt++;
>
> - if (!bio_flagged(bio, BIO_WORKINGSET) && unlikely(PageWorkingset(page)))
> - bio_set_flag(bio, BIO_WORKINGSET);
> + if (!bio_flagged(bio, BIO_WORKINGSET_FILE) &&
> + unlikely(PageWorkingset(page)) && !PageSwapBacked(page))
> + bio_set_flag(bio, BIO_WORKINGSET_FILE);
This needs to go out of the block I/O fast path, not grow even more
checks.
next prev parent reply other threads:[~2022-03-16 8:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 6:39 [PATCH] block/psi: make PSI annotations of submit_bio only work for file pages cgel.zte
2022-03-16 8:48 ` Christoph Hellwig [this message]
2022-03-17 2:18 ` CGEL
2022-03-21 14:33 ` Johannes Weiner
2022-03-22 2:47 ` CGEL
2022-03-22 13:27 ` Johannes Weiner
2022-03-23 6:10 ` CGEL
[not found] ` <20220323061058.GA2343452@cgel.zte@gmail.com>
2022-03-30 8:34 ` CGEL
2022-03-30 13:00 ` Johannes Weiner
2022-03-30 13:04 ` Christoph Hellwig
2022-03-30 13:49 ` Jens Axboe
2022-03-30 15:45 ` Johannes Weiner
2022-03-30 15:54 ` Christoph Hellwig
2022-03-30 16:17 ` Johannes Weiner
2022-03-31 5:15 ` Christoph Hellwig
2022-03-31 19:07 ` Johannes Weiner
2022-03-31 2:21 ` CGEL
2022-03-22 3:44 ` CGEL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjGkRT+ccoZ0ZNDq@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cgel.zte@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ran.xiaokai@zte.com.cn \
--cc=viro@zeniv.linux.org.uk \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox