From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>,
Johannes Weiner <hannes@cmpxchg.org>
Cc: CGEL <cgel.zte@gmail.com>,
viro@zeniv.linux.org.uk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
akpm@linux-foundation.org, Yang Yang <yang.yang29@zte.com.cn>,
Ran Xiaokai <ran.xiaokai@zte.com.cn>
Subject: Re: [PATCH] block/psi: make PSI annotations of submit_bio only work for file pages
Date: Wed, 30 Mar 2022 07:49:48 -0600 [thread overview]
Message-ID: <dbb7a09d-2833-240b-15af-4b72c4ea83bb@kernel.dk> (raw)
In-Reply-To: <YkRVSIG6QKfDK/ES@infradead.org>
On 3/30/22 7:04 AM, Christoph Hellwig wrote:
> On Wed, Mar 30, 2022 at 09:00:46AM -0400, Johannes Weiner wrote:
>> If you want type distinction, we should move it all into MM code, like
>> Christoph is saying. Were swap code handles anon refaults and the page
>> cache code handles file refaults. This would be my preferred layering,
>> and my original patch did that: https://lkml.org/lkml/2019/7/22/1070.
>
> FYI, I started redoing that version and I think with all the cleanups
> to filemap.c and the readahead code this can be done fairly nicely now:
>
> http://git.infradead.org/users/hch/block.git/commitdiff/666abb29c6db870d3941acc5ac19e83fbc72cfd4
This looks way better than hiding it deep down in the block layer.
--
Jens Axboe
next prev parent reply other threads:[~2022-03-30 13:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 6:39 [PATCH] block/psi: make PSI annotations of submit_bio only work for file pages cgel.zte
2022-03-16 8:48 ` Christoph Hellwig
2022-03-17 2:18 ` CGEL
2022-03-21 14:33 ` Johannes Weiner
2022-03-22 2:47 ` CGEL
2022-03-22 13:27 ` Johannes Weiner
2022-03-23 6:10 ` CGEL
[not found] ` <20220323061058.GA2343452@cgel.zte@gmail.com>
2022-03-30 8:34 ` CGEL
2022-03-30 13:00 ` Johannes Weiner
2022-03-30 13:04 ` Christoph Hellwig
2022-03-30 13:49 ` Jens Axboe [this message]
2022-03-30 15:45 ` Johannes Weiner
2022-03-30 15:54 ` Christoph Hellwig
2022-03-30 16:17 ` Johannes Weiner
2022-03-31 5:15 ` Christoph Hellwig
2022-03-31 19:07 ` Johannes Weiner
2022-03-31 2:21 ` CGEL
2022-03-22 3:44 ` CGEL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbb7a09d-2833-240b-15af-4b72c4ea83bb@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=cgel.zte@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ran.xiaokai@zte.com.cn \
--cc=viro@zeniv.linux.org.uk \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox