* [PATCH 3/3] ublk_drv: missing error code in ublk_add_dev()
@ 2022-07-18 11:14 Dan Carpenter
2022-07-18 12:24 ` Ming Lei
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-07-18 11:14 UTC (permalink / raw)
To: Jens Axboe, Ming Lei; +Cc: linux-block, kernel-janitors
This error path accidentally returns success instead of a negative
error code.
Fixes: cebbe577cb17 ("ublk_drv: fix request queue leak")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/block/ublk_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
index c0f9a5b4ed58..332472901ff8 100644
--- a/drivers/block/ublk_drv.c
+++ b/drivers/block/ublk_drv.c
@@ -1169,8 +1169,10 @@ static int ublk_add_dev(struct ublk_device *ub)
goto out_deinit_queues;
ub->ub_queue = blk_mq_init_queue(&ub->tag_set);
- if (IS_ERR(ub->ub_queue))
+ if (IS_ERR(ub->ub_queue)) {
+ err = PTR_ERR(ub->ub_queue);
goto out_cleanup_tags;
+ }
ub->ub_queue->queuedata = ub;
disk = ub->ub_disk = blk_mq_alloc_disk_for_queue(ub->ub_queue,
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/3] ublk_drv: missing error code in ublk_add_dev()
2022-07-18 11:14 [PATCH 3/3] ublk_drv: missing error code in ublk_add_dev() Dan Carpenter
@ 2022-07-18 12:24 ` Ming Lei
0 siblings, 0 replies; 2+ messages in thread
From: Ming Lei @ 2022-07-18 12:24 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jens Axboe, linux-block, kernel-janitors
On Mon, Jul 18, 2022 at 02:14:28PM +0300, Dan Carpenter wrote:
> This error path accidentally returns success instead of a negative
> error code.
>
> Fixes: cebbe577cb17 ("ublk_drv: fix request queue leak")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/block/ublk_drv.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
> index c0f9a5b4ed58..332472901ff8 100644
> --- a/drivers/block/ublk_drv.c
> +++ b/drivers/block/ublk_drv.c
> @@ -1169,8 +1169,10 @@ static int ublk_add_dev(struct ublk_device *ub)
> goto out_deinit_queues;
>
> ub->ub_queue = blk_mq_init_queue(&ub->tag_set);
> - if (IS_ERR(ub->ub_queue))
> + if (IS_ERR(ub->ub_queue)) {
> + err = PTR_ERR(ub->ub_queue);
> goto out_cleanup_tags;
> + }
Yang Yingliang has posted one same patch:
https://lore.kernel.org/linux-block/YtUOhUXBKG28bew4@T590/T/#t
Thanks,
Ming
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-18 12:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-18 11:14 [PATCH 3/3] ublk_drv: missing error code in ublk_add_dev() Dan Carpenter
2022-07-18 12:24 ` Ming Lei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox