* [PATCH 2/3] ublk_drv: uninitialized error code in ublk_ctrl_get_queue_affinity()
@ 2022-07-18 11:14 Dan Carpenter
2022-07-18 12:22 ` Ming Lei
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-07-18 11:14 UTC (permalink / raw)
To: Jens Axboe, Ming Lei; +Cc: linux-block, kernel-janitors
Initialize the "ret" variable so we don't return uninitialized data if
ublk_get_device_from_id() fails.
Fixes: 71f28f3136af ("ublk_drv: add io_uring based userspace block driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/block/ublk_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
index 97725d13e4bd..c0f9a5b4ed58 100644
--- a/drivers/block/ublk_drv.c
+++ b/drivers/block/ublk_drv.c
@@ -1298,13 +1298,12 @@ static int ublk_ctrl_get_queue_affinity(struct io_uring_cmd *cmd)
struct ublk_device *ub;
unsigned long queue;
unsigned int retlen;
- int ret;
+ int ret = -EINVAL;
ub = ublk_get_device_from_id(header->dev_id);
if (!ub)
goto out;
- ret = -EINVAL;
queue = header->data[0];
if (queue >= ub->dev_info.nr_hw_queues)
goto out;
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 2/3] ublk_drv: uninitialized error code in ublk_ctrl_get_queue_affinity()
2022-07-18 11:14 [PATCH 2/3] ublk_drv: uninitialized error code in ublk_ctrl_get_queue_affinity() Dan Carpenter
@ 2022-07-18 12:22 ` Ming Lei
0 siblings, 0 replies; 2+ messages in thread
From: Ming Lei @ 2022-07-18 12:22 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jens Axboe, linux-block, kernel-janitors, ming.lei
On Mon, Jul 18, 2022 at 02:14:18PM +0300, Dan Carpenter wrote:
> Initialize the "ret" variable so we don't return uninitialized data if
> ublk_get_device_from_id() fails.
>
> Fixes: 71f28f3136af ("ublk_drv: add io_uring based userspace block driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/block/ublk_drv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
> index 97725d13e4bd..c0f9a5b4ed58 100644
> --- a/drivers/block/ublk_drv.c
> +++ b/drivers/block/ublk_drv.c
> @@ -1298,13 +1298,12 @@ static int ublk_ctrl_get_queue_affinity(struct io_uring_cmd *cmd)
> struct ublk_device *ub;
> unsigned long queue;
> unsigned int retlen;
> - int ret;
> + int ret = -EINVAL;
This one has been fixed in for-5.20/block by "ublk_drv: fix build warning with
-Wmaybe-uninitialized and one sparse warning".
Thanks,
Ming
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-18 12:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-18 11:14 [PATCH 2/3] ublk_drv: uninitialized error code in ublk_ctrl_get_queue_affinity() Dan Carpenter
2022-07-18 12:22 ` Ming Lei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox