Re: [PATCH] block: ratelimit warning in bio_check_ro

[Ladislav Michl <oss-lists@triops.cz>]

Hi Christoph,

On Wed, Jun 07, 2023 at 08:30:02AM +0200, Christoph Hellwig wrote:
> On Wed, Jun 07, 2023 at 08:28:22AM +0200, Ladislav Michl wrote:
> > From: Ladislav Michl <ladis@linux-mips.org>
> > 
> > Until 57e95e4670d1 ("block: fix and cleanup bio_check_ro")
> > a WARN_ONCE was used to print a warning. Current pr_warn causes
> > log flood, so use pr_warn_ratelimited instead.
> > Once there adjust message to match the one used in bio_check_eod.
> 
> Do you have a case that hits this?  Beause we'd really need to fix it.

I hit that while working on customer's embedded board. There's eMMC
where boot partitions are locked after upgrade by writing 1 into
force_ro sysfs file. Pending writes are triggering this warnign.
Of course update scripts was fixed meanwhile and knowing what
process triggered warning was quite helpful. So there's nothing
to fix, it is just improved diagnostic and returning to (almost)
old behaviour.

> Otherwise this looks ok to me.