From: Christoph Hellwig <hch@lst.de>
To: Ladislav Michl <oss-lists@triops.cz>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] block: ratelimit warning in bio_check_ro
Date: Wed, 7 Jun 2023 08:30:02 +0200 [thread overview]
Message-ID: <20230607063002.GA21239@lst.de> (raw)
In-Reply-To: <ZIAjht591AEza3c4@lenoch>
On Wed, Jun 07, 2023 at 08:28:22AM +0200, Ladislav Michl wrote:
> From: Ladislav Michl <ladis@linux-mips.org>
>
> Until 57e95e4670d1 ("block: fix and cleanup bio_check_ro")
> a WARN_ONCE was used to print a warning. Current pr_warn causes
> log flood, so use pr_warn_ratelimited instead.
> Once there adjust message to match the one used in bio_check_eod.
Do you have a case that hits this? Beause we'd really need to fix it.
Otherwise this looks ok to me.
next prev parent reply other threads:[~2023-06-07 6:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 6:28 [PATCH] block: ratelimit warning in bio_check_ro Ladislav Michl
2023-06-07 6:30 ` Christoph Hellwig [this message]
2023-06-07 7:45 ` Ladislav Michl
2023-08-14 19:56 ` Ladislav Michl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607063002.GA21239@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=oss-lists@triops.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox