From: Christoph Hellwig <hch@infradead.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
Marc Smith <msmith626@gmail.com>
Subject: Re: [PATCH] block: flush the disk cache on BLKFLSBUF
Date: Mon, 26 Jun 2023 21:52:24 -0700 [thread overview]
Message-ID: <ZJprCPEYfqIpqClP@infradead.org> (raw)
In-Reply-To: <1a33ace-57f9-9ef9-b967-d6617ca33089@redhat.com>
On Mon, Jun 26, 2023 at 10:25:28PM +0200, Mikulas Patocka wrote:
> The BLKFLSBUF ioctl doesn't send the flush bio to the block device, thus
> flushed data may be lurking in the disk cache and they may not be really
> flushed to the stable storage.
>
> This patch adds the call to blkdev_issue_flush to blkdev_flushbuf.
Umm, why? This is an ioctl no one should be using, and we certainly
should not add new functionality to it. Can you explain what you're
trying to do here?
next prev parent reply other threads:[~2023-06-27 4:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 20:25 [PATCH] block: flush the disk cache on BLKFLSBUF Mikulas Patocka
2023-06-27 4:52 ` Christoph Hellwig [this message]
2023-06-27 15:31 ` Mikulas Patocka
2023-06-27 15:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJprCPEYfqIpqClP@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=msmith626@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox