Re: RIP on discard, JMicron USB adaptor

Re: RIP on discard, JMicron USB adaptor

[Alan Stern]

On Wed, Feb 28, 2024 at 01:22:12PM +0100, Harald Dunkel wrote:
> Hi folks,
> 
> not sure if this was supposed to happen:
> 
> [1400821.811585] ------------[ cut here ]------------
> [1400821.811594] WARNING: CPU: 0 PID: 614303 at block/blk-lib.c:50 __blkdev_issue_discard+0x14b/0x180
> [1400821.811612] Modules linked in: cdc_mbim cdc_wdm tcp_diag udp_diag inet_diag exfat snd_seq_dummy snd_hrtimer snd_seq_midi snd_seq_midi_event snd_seq cpufreq_userspace cpufreq_conservative cpufreq_powersave cpufreq_ondemand cts rpcsec_gss_krb5 nfsv4 dns_resolver nfs lockd grace fscache netfs scsi_transport_iscsi nvme_fabrics dell_rbu rfkill qrtr dcdbas uinput binfmt_misc nls_ascii nls_cp437 vfat fat nvidia_drm(POE) nvidia_modeset(POE) intel_rapl_msr intel_rapl_common x86_pkg_temp_thermal snd_hda_codec_realtek intel_powerclamp xt_recent snd_hda_codec_generic ledtrig_audio coretemp snd_sof_pci_intel_tgl snd_sof_intel_hda_common soundwire_intel soundwire_generic_allocation soundwire_cadence snd_sof_intel_hda snd_sof_pci snd_sof_xtensa_dsp snd_sof snd_sof_utils snd_soc_hdac_hda snd_hda_codec_hdmi snd_hda_ext_core snd_soc_acpi_intel_match snd_soc_acpi snd_soc_core snd_compress soundwire_bus snd_hda_intel snd_usb_audio snd_intel_dspcfg br_netfilter snd_intel_sdw_acpi kvm_intel overlay
> [1400821.811692]  snd_usbmidi_lib i915 xt_comment snd_hda_codec uvcvideo xt_CHECKSUM snd_rawmidi snd_hda_core videobuf2_vmalloc kvm drm_buddy snd_seq_device nf_tables snd_hwdep videobuf2_memops drm_display_helper videobuf2_v4l2 nfnetlink snd_pcm_oss irqbypass videobuf2_common bridge snd_mixer_oss cec 8021q videodev rapl garp rc_core intel_cstate mei_hdcp nvidia(POE) snd_pcm evdev stp mc wmi_bmof gigabyte_wmi mrp intel_uncore ttm iTCO_wdt llc snd_timer intel_pmc_bxt bonding pcspkr drm_kms_helper macvlan snd iTCO_vendor_support intel_hid tls watchdog soundcore veth i2c_algo_bit sg sparse_keymap acpi_pad intel_pmc_core acpi_tad button mei_me mei iptable_nat iptable_mangle iptable_filter ip6table_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 auth_rpcgss ip6table_mangle ip6table_filter ip6_tables drm fuse loop efi_pstore sunrpc configfs ip_tables x_tables autofs4 ext4 crc16 mbcache jbd2 btrfs blake2b_generic zstd_compress efivarfs raid10 raid456 async_raid6_recov async_memcpy async_pq
> [1400821.811799]  async_xor async_tx xor raid6_pq libcrc32c crc32c_generic raid0 multipath linear hid_logitech_hidpp hid_logitech_dj uas usb_storage hid_generic usbhid hid cdc_ncm cdc_ether usbnet raid1 md_mod r8152 mii sd_mod dm_mod crc32_pclmul crc32c_intel ghash_clmulni_intel sha512_ssse3 sha512_generic sha256_ssse3 sha1_ssse3 nvme nvme_core ahci xhci_pci t10_pi libahci crc64_rocksoft_generic xhci_hcd libata aesni_intel r8169 realtek crc64_rocksoft crc_t10dif mdio_devres usbcore scsi_mod crypto_simd libphy cryptd crct10dif_generic intel_lpss_pci i2c_i801 crct10dif_pclmul crc64 crct10dif_common intel_lpss i2c_smbus idma64 usb_common scsi_common fan video wmi pinctrl_alderlake
> [1400821.811868] CPU: 0 PID: 614303 Comm: blkdiscard Tainted: P           OE      6.1.0-18-amd64 #1  Debian 6.1.76-1
> [1400821.811875] Hardware name: Gigabyte Technology Co., Ltd. Z790 GAMING X/Z790 GAMING X, BIOS F9b 11/10/2023
> [1400821.811878] RIP: 0010:__blkdev_issue_discard+0x14b/0x180
> [1400821.811887] Code: 48 39 d8 75 8b f7 da 89 d3 c1 eb 09 eb 85 48 8b 04 24 4c 89 20 48 83 c4 08 31 c0 5b 5d 41 5c 41 5d 41 5e 41 5f c3 cc cc cc cc <0f> 0b 48 c7 c6 80 fd 0a a9 48 c7 c7 40 2c b9 a9 e8 60 45 4f 00 85
> [1400821.811891] RSP: 0018:ffffb3d7a50d7d50 EFLAGS: 00010246
> [1400821.811896] RAX: ffff9fb0cb248750 RBX: ffff9fbb794612c0 RCX: ffff9fb60167be80
> [1400821.811899] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff9fbb794612c0
> [1400821.811902] RBP: 0000000000000cc0 R08: ffffb3d7a50d7d90 R09: fffff5f4d6f7efc0
> [1400821.811904] R10: 000000000ee778ff R11: 0000000000000000 R12: 0000000000000000
> [1400821.811907] R13: 00000000773bc800 R14: 000000ee77900000 R15: ffff9fbb794612c0
> [1400821.811910] FS:  00007f2af0e95740(0000) GS:ffff9fbb7f200000(0000) knlGS:0000000000000000
> [1400821.811914] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [1400821.811917] CR2: 00007ffc65eec170 CR3: 00000002dcf78000 CR4: 0000000000750ef0
> [1400821.811920] PKRU: 55555554
> [1400821.811923] Call Trace:
> [1400821.811926]  <TASK>
> [1400821.811931]  ? __warn+0x7d/0xc0
> [1400821.811938]  ? __blkdev_issue_discard+0x14b/0x180
> [1400821.811945]  ? report_bug+0xe2/0x150
> [1400821.811955]  ? handle_bug+0x41/0x70
> [1400821.811959]  ? exc_invalid_op+0x13/0x60
> [1400821.811963]  ? asm_exc_invalid_op+0x16/0x20
> [1400821.811974]  ? __blkdev_issue_discard+0x14b/0x180
> [1400821.811982]  blkdev_issue_discard+0x7e/0xe0
> [1400821.811990]  blkdev_common_ioctl+0x61f/0xa30
> [1400821.811999]  blkdev_ioctl+0x104/0x270
> [1400821.812006]  __x64_sys_ioctl+0x8d/0xd0
> [1400821.812013]  do_syscall_64+0x58/0xc0
> [1400821.812017]  ? do_user_addr_fault+0x1b0/0x580
> [1400821.812023]  ? exit_to_user_mode_prepare+0x40/0x1e0
> [1400821.812030]  entry_SYSCALL_64_after_hwframe+0x64/0xce
> [1400821.812038] RIP: 0033:0x7f2af0f95c5b
> [1400821.812042] Code: 00 48 89 44 24 18 31 c0 48 8d 44 24 60 c7 04 24 10 00 00 00 48 89 44 24 08 48 8d 44 24 20 48 89 44 24 10 b8 10 00 00 00 0f 05 <89> c2 3d 00 f0 ff ff 77 1c 48 8b 44 24 18 64 48 2b 04 25 28 00 00
> [1400821.812046] RSP: 002b:00007ffc65ecec40 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> [1400821.812051] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f2af0f95c5b
> [1400821.812054] RDX: 00007ffc65eced00 RSI: 0000000000001277 RDI: 0000000000000003
> [1400821.812056] RBP: 0000000000000000 R08: 0000000000000007 R09: 0000563c2300a2f0
> [1400821.812058] R10: 00007ffc65eec170 R11: 0000000000000246 R12: 000000ee77900000
> [1400821.812061] R13: 0000000000000003 R14: 0000563c2300a2f0 R15: 0000000000000000
> [1400821.812065]  </TASK>
> [1400821.812067] ---[ end trace 0000000000000000 ]---
> 
> I tried a discard on a Samsung PM981 1TB SSD (m.2) using a JMicron USB adaptor.
> 
> udev rule:
> 
> ACTION=="add|change", ATTRS{idVendor}=="152d", ATTRS{idProduct}=="0583", SUBSYSTEM=="scsi_disk", ATTR{provisioning_mode}="unmap"
> 
> Probably I was too optimistic.

Notice that the USB layer does not show up at all in the stack dump 
above, but the block layer figures prominently.  This strongly suggests 
that the bug lies in the block layer.

CC'ing the appropriate mailing list and maintainer.

Alan Stern

Re: RIP on discard, JMicron USB adaptor

[Keith Busch]

On Wed, Feb 28, 2024 at 10:46:39AM -0500, Alan Stern wrote:
> On Wed, Feb 28, 2024 at 01:22:12PM +0100, Harald Dunkel wrote:
> > [1400821.811585] ------------[ cut here ]------------
> > [1400821.811594] WARNING: CPU: 0 PID: 614303 at block/blk-lib.c:50 __blkdev_issue_discard+0x14b/0x180
> > [1400821.811868] CPU: 0 PID: 614303 Comm: blkdiscard Tainted: P           OE      6.1.0-18-amd64 #1  Debian 6.1.76-1
> > [1400821.811875] Hardware name: Gigabyte Technology Co., Ltd. Z790 GAMING X/Z790 GAMING X, BIOS F9b 11/10/2023
> > [1400821.811878] RIP: 0010:__blkdev_issue_discard+0x14b/0x180
> > [1400821.811887] Code: 48 39 d8 75 8b f7 da 89 d3 c1 eb 09 eb 85 48 8b 04 24 4c 89 20 48 83 c4 08 31 c0 5b 5d 41 5c 41 5d 41 5e 41 5f c3 cc cc cc cc <0f> 0b 48 c7 c6 80 fd 0a a9 48 c7 c7 40 2c b9 a9 e8 60 45 4f 00 85
> > [1400821.811891] RSP: 0018:ffffb3d7a50d7d50 EFLAGS: 00010246
> > [1400821.811896] RAX: ffff9fb0cb248750 RBX: ffff9fbb794612c0 RCX: ffff9fb60167be80
> > [1400821.811899] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff9fbb794612c0
> > [1400821.811902] RBP: 0000000000000cc0 R08: ffffb3d7a50d7d90 R09: fffff5f4d6f7efc0
> > [1400821.811904] R10: 000000000ee778ff R11: 0000000000000000 R12: 0000000000000000
> > [1400821.811907] R13: 00000000773bc800 R14: 000000ee77900000 R15: ffff9fbb794612c0
> > [1400821.811910] FS:  00007f2af0e95740(0000) GS:ffff9fbb7f200000(0000) knlGS:0000000000000000
> > [1400821.811914] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > [1400821.811917] CR2: 00007ffc65eec170 CR3: 00000002dcf78000 CR4: 0000000000750ef0
> > [1400821.811920] PKRU: 55555554
> > [1400821.811923] Call Trace:
> > [1400821.811926]  <TASK>
> > [1400821.811931]  ? __warn+0x7d/0xc0
> > [1400821.811938]  ? __blkdev_issue_discard+0x14b/0x180
> > [1400821.811945]  ? report_bug+0xe2/0x150
> > [1400821.811955]  ? handle_bug+0x41/0x70
> > [1400821.811959]  ? exc_invalid_op+0x13/0x60
> > [1400821.811963]  ? asm_exc_invalid_op+0x16/0x20
> > [1400821.811974]  ? __blkdev_issue_discard+0x14b/0x180
> > [1400821.811982]  blkdev_issue_discard+0x7e/0xe0
> > [1400821.811990]  blkdev_common_ioctl+0x61f/0xa30
> > [1400821.811999]  blkdev_ioctl+0x104/0x270
> > [1400821.812006]  __x64_sys_ioctl+0x8d/0xd0
> > [1400821.812013]  do_syscall_64+0x58/0xc0
> > [1400821.812017]  ? do_user_addr_fault+0x1b0/0x580
> > [1400821.812023]  ? exit_to_user_mode_prepare+0x40/0x1e0
> > [1400821.812030]  entry_SYSCALL_64_after_hwframe+0x64/0xce
> > [1400821.812038] RIP: 0033:0x7f2af0f95c5b
> > [1400821.812042] Code: 00 48 89 44 24 18 31 c0 48 8d 44 24 60 c7 04 24 10 00 00 00 48 89 44 24 08 48 8d 44 24 20 48 89 44 24 10 b8 10 00 00 00 0f 05 <89> c2 3d 00 f0 ff ff 77 1c 48 8b 44 24 18 64 48 2b 04 25 28 00 00
> > [1400821.812046] RSP: 002b:00007ffc65ecec40 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> > [1400821.812051] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f2af0f95c5b
> > [1400821.812054] RDX: 00007ffc65eced00 RSI: 0000000000001277 RDI: 0000000000000003
> > [1400821.812056] RBP: 0000000000000000 R08: 0000000000000007 R09: 0000563c2300a2f0
> > [1400821.812058] R10: 00007ffc65eec170 R11: 0000000000000246 R12: 000000ee77900000
> > [1400821.812061] R13: 0000000000000003 R14: 0000563c2300a2f0 R15: 0000000000000000
> > [1400821.812065]  </TASK>
> > [1400821.812067] ---[ end trace 0000000000000000 ]---
> > 
> > I tried a discard on a Samsung PM981 1TB SSD (m.2) using a JMicron USB adaptor.
> > 
> > udev rule:
> > 
> > ACTION=="add|change", ATTRS{idVendor}=="152d", ATTRS{idProduct}=="0583", SUBSYSTEM=="scsi_disk", ATTR{provisioning_mode}="unmap"
> > 
> > Probably I was too optimistic.
> 
> Notice that the USB layer does not show up at all in the stack dump 
> above, but the block layer figures prominently.  This strongly suggests 
> that the bug lies in the block layer.
> 
> CC'ing the appropriate mailing list and maintainer.

In the code comments above the WARN, this condition indicates "the
discard granularity isn't set by buggy device driver". The block layer
needs this set if your driver also sets the max_discard_sectors limit.

Re: RIP on discard, JMicron USB adaptor

[Alan Stern]

On Wed, Feb 28, 2024 at 08:55:27AM -0700, Keith Busch wrote:
> On Wed, Feb 28, 2024 at 10:46:39AM -0500, Alan Stern wrote:
> > On Wed, Feb 28, 2024 at 01:22:12PM +0100, Harald Dunkel wrote:
> > > [1400821.811585] ------------[ cut here ]------------
> > > [1400821.811594] WARNING: CPU: 0 PID: 614303 at block/blk-lib.c:50 __blkdev_issue_discard+0x14b/0x180
> > > [1400821.811868] CPU: 0 PID: 614303 Comm: blkdiscard Tainted: P           OE      6.1.0-18-amd64 #1  Debian 6.1.76-1
> > > [1400821.811875] Hardware name: Gigabyte Technology Co., Ltd. Z790 GAMING X/Z790 GAMING X, BIOS F9b 11/10/2023
> > > [1400821.811878] RIP: 0010:__blkdev_issue_discard+0x14b/0x180

> > > I tried a discard on a Samsung PM981 1TB SSD (m.2) using a JMicron USB adaptor.
> > > 
> > > udev rule:
> > > 
> > > ACTION=="add|change", ATTRS{idVendor}=="152d", ATTRS{idProduct}=="0583", SUBSYSTEM=="scsi_disk", ATTR{provisioning_mode}="unmap"
> > > 
> > > Probably I was too optimistic.
> > 
> > Notice that the USB layer does not show up at all in the stack dump 
> > above, but the block layer figures prominently.  This strongly suggests 
> > that the bug lies in the block layer.
> > 
> > CC'ing the appropriate mailing list and maintainer.
> 
> In the code comments above the WARN, this condition indicates "the
> discard granularity isn't set by buggy device driver". The block layer
> needs this set if your driver also sets the max_discard_sectors limit.

The usb-storage and uas drivers do not set any of these; however, the 
SCSI sd driver does.  Maybe that's where the problem lies.  Adding more 
CC's.

Alan Stern

Re: RIP on discard, JMicron USB adaptor

[Oliver Neukum]

On 28.02.24 17:01, Alan Stern wrote:

>> In the code comments above the WARN, this condition indicates "the
>> discard granularity isn't set by buggy device driver". The block layer
>> needs this set if your driver also sets the max_discard_sectors limit.
> 
> The usb-storage and uas drivers do not set any of these; however, the
> SCSI sd driver does.  Maybe that's where the problem lies.  Adding more
> CC's.

Hi,

that seems to be conditional on READ_CAPACITY_16 being used.
 From the cropped dmesg we cannot tell. We need more.

	Regards
		Oliver

Re: RIP on discard, JMicron USB adaptor

[Harald Dunkel]

On 2024-02-28 17:11:16, Oliver Neukum wrote:
> 
> Hi,
> 
> that seems to be conditional on READ_CAPACITY_16 being used.
>   From the cropped dmesg we cannot tell. We need more.
> 
> 	Regards
> 		Oliver

Hope this helps:

```
[1399898.541790] usb 2-2: new SuperSpeed Plus Gen 2x1 USB device number 77 using xhci_hcd
[1399898.562427] usb 2-2: New USB device found, idVendor=152d, idProduct=0583, bcdDevice=31.08
[1399898.562439] usb 2-2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[1399898.562444] usb 2-2: Product: USB Storage Device
[1399898.562447] usb 2-2: Manufacturer: JMicron
[1399898.562449] usb 2-2: SerialNumber: DD56419885A7C
[1399898.584864] scsi host9: uas
[1399898.585396] scsi 9:0:0:0: Direct-Access     CT500P2S SD8              3108 PQ: 0 ANSI: 6
[1399898.587031] sd 9:0:0:0: Attached scsi generic sg5 type 0
[1399902.581473] usb 2-2: USB disconnect, device number 77
[1399902.581684] sd 9:0:0:0: [sdf] tag#26 uas_zap_pending 0 uas-tag 1 inflight: CMD
[1399902.581692] sd 9:0:0:0: [sdf] tag#26 CDB: Test Unit Ready 00 00 00 00 00 00
[1399902.581827] sd 9:0:0:0: [sdf] Test Unit Ready failed: Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK
[1399902.581859] sd 9:0:0:0: [sdf] Read Capacity(16) failed: Result: hostbyte=DID_ERROR driverbyte=DRIVER_OK
[1399902.581864] sd 9:0:0:0: [sdf] Sense not available.
[1399902.581874] sd 9:0:0:0: [sdf] Read Capacity(10) failed: Result: hostbyte=DID_ERROR driverbyte=DRIVER_OK
[1399902.581877] sd 9:0:0:0: [sdf] Sense not available.
[1399902.581884] sd 9:0:0:0: [sdf] 0 512-byte logical blocks: (0 B/0 B)
[1399902.581888] sd 9:0:0:0: [sdf] 0-byte physical blocks
[1399902.581894] sd 9:0:0:0: [sdf] Write Protect is off
[1399902.581897] sd 9:0:0:0: [sdf] Mode Sense: 00 00 00 00
[1399902.581902] sd 9:0:0:0: [sdf] Asking for cache data failed
[1399902.581905] sd 9:0:0:0: [sdf] Assuming drive cache: write through
[1399902.581910] sd 9:0:0:0: [sdf] Preferred minimum I/O size 4096 bytes not a multiple of physical block size (0 bytes)
[1399902.581914] sd 9:0:0:0: [sdf] Optimal transfer size 33553920 bytes not a multiple of physical block size (0 bytes)
[1399902.582741] sd 9:0:0:0: [sdf] Attached SCSI disk
[1399903.684404] usb usb2-port2: config error
[1399904.133524] usb 2-2: new SuperSpeed Plus Gen 2x1 USB device number 78 using xhci_hcd
[1399904.154230] usb 2-2: New USB device found, idVendor=152d, idProduct=0583, bcdDevice=31.08
[1399904.154241] usb 2-2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[1399904.154246] usb 2-2: Product: USB Storage Device
[1399904.154249] usb 2-2: Manufacturer: JMicron
[1399904.154251] usb 2-2: SerialNumber: DD56419885A7C
[1399904.161183] scsi host9: uas
[1399904.162037] scsi 9:0:0:0: Direct-Access     SAMSUNG  MZVLB1T0HALR     3108 PQ: 0 ANSI: 6
[1399904.164156] sd 9:0:0:0: Attached scsi generic sg5 type 0
[1399904.164524] sd 9:0:0:0: [sdf] 2000409264 512-byte logical blocks: (1.02 TB/954 GiB)
[1399904.164534] sd 9:0:0:0: [sdf] 4096-byte physical blocks
[1399904.164685] sd 9:0:0:0: [sdf] Write Protect is off
[1399904.164689] sd 9:0:0:0: [sdf] Mode Sense: 5f 00 00 08
[1399904.164952] sd 9:0:0:0: [sdf] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
[1399904.164957] sd 9:0:0:0: [sdf] Preferred minimum I/O size 4096 bytes
[1399904.164960] sd 9:0:0:0: [sdf] Optimal transfer size 33553920 bytes not a multiple of preferred minimum block size (4096 bytes)
[1399904.169442]  sdf: sdf1 sdf2
[1399904.169884] sd 9:0:0:0: [sdf] Attached SCSI disk
[1399976.536628]  sdf: sdf1 sdf2
[1400046.913154]  sdf: sdf1
[1400783.346828] usb 2-2: USB disconnect, device number 78
[1400783.410736] sd 9:0:0:0: [sdf] Synchronizing SCSI cache
[1400783.650712] sd 9:0:0:0: [sdf] Synchronize Cache(10) failed: Result: hostbyte=DID_ERROR driverbyte=DRIVER_OK
[1400804.017811] usb 1-12.2: new high-speed USB device number 5 using xhci_hcd
[1400804.166350] usb 1-12.2: New USB device found, idVendor=152d, idProduct=0583, bcdDevice=31.08
[1400804.166362] usb 1-12.2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[1400804.166366] usb 1-12.2: Product: USB Storage Device
[1400804.166369] usb 1-12.2: Manufacturer: JMicron
[1400804.166372] usb 1-12.2: SerialNumber: DD56419885A7C
[1400804.171592] scsi host9: uas
[1400804.172318] scsi 9:0:0:0: Direct-Access     SAMSUNG  MZVLB1T0HALR     3108 PQ: 0 ANSI: 6
[1400804.174579] sd 9:0:0:0: Attached scsi generic sg5 type 0
[1400806.348784] sd 9:0:0:0: [sdf] 2000409264 512-byte logical blocks: (1.02 TB/954 GiB)
[1400806.348791] sd 9:0:0:0: [sdf] 4096-byte physical blocks
[1400806.348991] sd 9:0:0:0: [sdf] Write Protect is off
[1400806.348994] sd 9:0:0:0: [sdf] Mode Sense: 6b 00 00 08
[1400806.349351] sd 9:0:0:0: [sdf] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
[1400806.349354] sd 9:0:0:0: [sdf] Preferred minimum I/O size 4096 bytes
[1400806.349355] sd 9:0:0:0: [sdf] Optimal transfer size 33553920 bytes not a multiple of preferred minimum block size (4096 bytes)
[1400806.353357]  sdf: sdf1
[1400806.353638] sd 9:0:0:0: [sdf] Attached SCSI disk
[1400821.811585] ------------[ cut here ]------------
[1400821.811594] WARNING: CPU: 0 PID: 614303 at block/blk-lib.c:50 __blkdev_issue_discard+0x14b/0x180
[1400821.811612] Modules linked in: cdc_mbim cdc_wdm tcp_diag udp_diag inet_diag exfat snd_seq_dummy snd_hrtimer snd_seq_midi snd_seq_midi_event snd_seq cpufreq_userspace cpufreq_conservative cpufreq_powersave cpufreq_ondemand cts rpcsec_gss_krb5 nfsv4 dns_resolver nfs lockd grace fscache netfs 
scsi_transport_iscsi nvme_fabrics dell_rbu rfkill qrtr dcdbas uinput binfmt_misc nls_ascii nls_cp437 vfat fat nvidia_drm(POE) nvidia_modeset(POE) intel_rapl_msr intel_rapl_common x86_pkg_temp_thermal snd_hda_codec_realtek intel_powerclamp xt_recent snd_hda_codec_generic ledtrig_audio coretemp 
snd_sof_pci_intel_tgl snd_sof_intel_hda_common soundwire_intel soundwire_generic_allocation soundwire_cadence snd_sof_intel_hda snd_sof_pci snd_sof_xtensa_dsp snd_sof snd_sof_utils snd_soc_hdac_hda snd_hda_codec_hdmi snd_hda_ext_core snd_soc_acpi_intel_match snd_soc_acpi snd_soc_core snd_compress 
soundwire_bus snd_hda_intel snd_usb_audio snd_intel_dspcfg br_netfilter snd_intel_sdw_acpi kvm_intel overlay
[1400821.811692]  snd_usbmidi_lib i915 xt_comment snd_hda_codec uvcvideo xt_CHECKSUM snd_rawmidi snd_hda_core videobuf2_vmalloc kvm drm_buddy snd_seq_device nf_tables snd_hwdep videobuf2_memops drm_display_helper videobuf2_v4l2 nfnetlink snd_pcm_oss irqbypass videobuf2_common bridge snd_mixer_oss 
cec 8021q videodev rapl garp rc_core intel_cstate mei_hdcp nvidia(POE) snd_pcm evdev stp mc wmi_bmof gigabyte_wmi mrp intel_uncore ttm iTCO_wdt llc snd_timer intel_pmc_bxt bonding pcspkr drm_kms_helper macvlan snd iTCO_vendor_support intel_hid tls watchdog soundcore veth i2c_algo_bit sg 
sparse_keymap acpi_pad intel_pmc_core acpi_tad button mei_me mei iptable_nat iptable_mangle iptable_filter ip6table_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 auth_rpcgss ip6table_mangle ip6table_filter ip6_tables drm fuse loop efi_pstore sunrpc configfs ip_tables x_tables autofs4 ext4 
crc16 mbcache jbd2 btrfs blake2b_generic zstd_compress efivarfs raid10 raid456 async_raid6_recov async_memcpy async_pq
[1400821.811799]  async_xor async_tx xor raid6_pq libcrc32c crc32c_generic raid0 multipath linear hid_logitech_hidpp hid_logitech_dj uas usb_storage hid_generic usbhid hid cdc_ncm cdc_ether usbnet raid1 md_mod r8152 mii sd_mod dm_mod crc32_pclmul crc32c_intel ghash_clmulni_intel sha512_ssse3 
sha512_generic sha256_ssse3 sha1_ssse3 nvme nvme_core ahci xhci_pci t10_pi libahci crc64_rocksoft_generic xhci_hcd libata aesni_intel r8169 realtek crc64_rocksoft crc_t10dif mdio_devres usbcore scsi_mod crypto_simd libphy cryptd crct10dif_generic intel_lpss_pci i2c_i801 crct10dif_pclmul crc64 
crct10dif_common intel_lpss i2c_smbus idma64 usb_common scsi_common fan video wmi pinctrl_alderlake
[1400821.811868] CPU: 0 PID: 614303 Comm: blkdiscard Tainted: P           OE      6.1.0-18-amd64 #1  Debian 6.1.76-1
[1400821.811875] Hardware name: Gigabyte Technology Co., Ltd. Z790 GAMING X/Z790 GAMING X, BIOS F9b 11/10/2023
[1400821.811878] RIP: 0010:__blkdev_issue_discard+0x14b/0x180
[1400821.811887] Code: 48 39 d8 75 8b f7 da 89 d3 c1 eb 09 eb 85 48 8b 04 24 4c 89 20 48 83 c4 08 31 c0 5b 5d 41 5c 41 5d 41 5e 41 5f c3 cc cc cc cc <0f> 0b 48 c7 c6 80 fd 0a a9 48 c7 c7 40 2c b9 a9 e8 60 45 4f 00 85
[1400821.811891] RSP: 0018:ffffb3d7a50d7d50 EFLAGS: 00010246
[1400821.811896] RAX: ffff9fb0cb248750 RBX: ffff9fbb794612c0 RCX: ffff9fb60167be80
[1400821.811899] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff9fbb794612c0
[1400821.811902] RBP: 0000000000000cc0 R08: ffffb3d7a50d7d90 R09: fffff5f4d6f7efc0
[1400821.811904] R10: 000000000ee778ff R11: 0000000000000000 R12: 0000000000000000
[1400821.811907] R13: 00000000773bc800 R14: 000000ee77900000 R15: ffff9fbb794612c0
[1400821.811910] FS:  00007f2af0e95740(0000) GS:ffff9fbb7f200000(0000) knlGS:0000000000000000
[1400821.811914] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[1400821.811917] CR2: 00007ffc65eec170 CR3: 00000002dcf78000 CR4: 0000000000750ef0
[1400821.811920] PKRU: 55555554
[1400821.811923] Call Trace:
[1400821.811926]  <TASK>
[1400821.811931]  ? __warn+0x7d/0xc0
[1400821.811938]  ? __blkdev_issue_discard+0x14b/0x180
[1400821.811945]  ? report_bug+0xe2/0x150
[1400821.811955]  ? handle_bug+0x41/0x70
[1400821.811959]  ? exc_invalid_op+0x13/0x60
[1400821.811963]  ? asm_exc_invalid_op+0x16/0x20
[1400821.811974]  ? __blkdev_issue_discard+0x14b/0x180
[1400821.811982]  blkdev_issue_discard+0x7e/0xe0
[1400821.811990]  blkdev_common_ioctl+0x61f/0xa30
[1400821.811999]  blkdev_ioctl+0x104/0x270
[1400821.812006]  __x64_sys_ioctl+0x8d/0xd0
[1400821.812013]  do_syscall_64+0x58/0xc0
[1400821.812017]  ? do_user_addr_fault+0x1b0/0x580
[1400821.812023]  ? exit_to_user_mode_prepare+0x40/0x1e0
[1400821.812030]  entry_SYSCALL_64_after_hwframe+0x64/0xce
[1400821.812038] RIP: 0033:0x7f2af0f95c5b
[1400821.812042] Code: 00 48 89 44 24 18 31 c0 48 8d 44 24 60 c7 04 24 10 00 00 00 48 89 44 24 08 48 8d 44 24 20 48 89 44 24 10 b8 10 00 00 00 0f 05 <89> c2 3d 00 f0 ff ff 77 1c 48 8b 44 24 18 64 48 2b 04 25 28 00 00
[1400821.812046] RSP: 002b:00007ffc65ecec40 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
[1400821.812051] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f2af0f95c5b
[1400821.812054] RDX: 00007ffc65eced00 RSI: 0000000000001277 RDI: 0000000000000003
[1400821.812056] RBP: 0000000000000000 R08: 0000000000000007 R09: 0000563c2300a2f0
[1400821.812058] R10: 00007ffc65eec170 R11: 0000000000000246 R12: 000000ee77900000
[1400821.812061] R13: 0000000000000003 R14: 0000563c2300a2f0 R15: 0000000000000000
[1400821.812065]  </TASK>
[1400821.812067] ---[ end trace 0000000000000000 ]---
[1400821.812070] sdf1: Error: discard_granularity is 0.
[1401126.140729] pcieport 0000:00:06.0: AER: Corrected error received: 0000:00:06.0
[1401126.140746] pcieport 0000:00:06.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID)
[1401126.140750] pcieport 0000:00:06.0:   device [8086:a74d] error status/mask=00000001/00002000
[1401126.140755] pcieport 0000:00:06.0:    [ 0] RxErr                  (First)
[1402010.765351] sdf1: Error: discard_granularity is 0.
[1402075.882687] EXT4-fs (sdf1): mounted filesystem with ordered data mode. Quota mode: none.
[1403520.146976] pcieport 0000:00:06.0: AER: Corrected error received: 0000:00:06.0
[1403520.146992] pcieport 0000:00:06.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID)
[1403520.146996] pcieport 0000:00:06.0:   device [8086:a74d] error status/mask=00000001/00002000
[1403520.147001] pcieport 0000:00:06.0:    [ 0] RxErr                  (First)
[1405438.512551] pcieport 0000:00:06.0: AER: Corrected error received: 0000:00:06.0
[1405438.512567] pcieport 0000:00:06.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID)
[1405438.512572] pcieport 0000:00:06.0:   device [8086:a74d] error status/mask=00000001/00002000
[1405438.512577] pcieport 0000:00:06.0:    [ 0] RxErr                  (First)
[1405970.427563] tun: Universal TUN/TAP device driver, 1.6
[1405970.427818] br0: port 2(vnet0) entered blocking state
[1405970.427820] br0: port 2(vnet0) entered disabled state
[1405970.427841] device vnet0 entered promiscuous mode
[1405970.427947] br0: port 2(vnet0) entered blocking state
[1405970.427948] br0: port 2(vnet0) entered forwarding state
[1406317.336783] EXT4-fs (sdf1): unmounting filesystem.
[1406372.516061] usb 1-12.2: USB disconnect, device number 5
[1406372.575968] sd 9:0:0:0: [sdf] Synchronizing SCSI cache
[1406372.815945] sd 9:0:0:0: [sdf] Synchronize Cache(10) failed: Result: hostbyte=DID_ERROR driverbyte=DRIVER_OK
```

Sorry, I should have included this right from the start.


Regards
Harri

Re: RIP on discard, JMicron USB adaptor

[Harald Dunkel]

[-- Attachment #1: Type: text/plain, Size: 132 bytes --]

Good news (sort of): I was able to reproduce the problem after a
power cycle. Full dmesg output is attached. Hope this helps.

Harri

[-- Attachment #2: dmesg.full.txt.gz --]
[-- Type: application/gzip, Size: 21622 bytes --]

Re: RIP on discard, JMicron USB adaptor

[Harald Dunkel]

On 2024-02-29 08:31:51, Harald Dunkel wrote:
> Good news (sort of): I was able to reproduce the problem after a
> power cycle. Full dmesg output is attached. Hope this helps.
> 

And for 6.7.6:

```
[Thu Feb 29 09:11:05 2024] usb 1-4: reset high-speed USB device number 3 using xhci_hcd
[Thu Feb 29 09:11:10 2024] logitech-hidpp-device 0003:046D:4082.0007: HID++ 4.5 device connected.
[Thu Feb 29 09:11:37 2024] usb 1-12.1: new high-speed USB device number 13 using xhci_hcd
[Thu Feb 29 09:11:38 2024] usb 1-12.1: New USB device found, idVendor=152d, idProduct=0583, bcdDevice=31.08
[Thu Feb 29 09:11:38 2024] usb 1-12.1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[Thu Feb 29 09:11:38 2024] usb 1-12.1: Product: USB Storage Device
[Thu Feb 29 09:11:38 2024] usb 1-12.1: Manufacturer: JMicron
[Thu Feb 29 09:11:38 2024] usb 1-12.1: SerialNumber: DD56419885A7C
[Thu Feb 29 09:11:38 2024] scsi host9: uas
[Thu Feb 29 09:11:38 2024] scsi 9:0:0:0: Direct-Access     SAMSUNG  MZVLB1T0HALR     3108 PQ: 0 ANSI: 6
[Thu Feb 29 09:11:38 2024] sd 9:0:0:0: Attached scsi generic sg5 type 0
[Thu Feb 29 09:11:40 2024] sd 9:0:0:0: [sdf] 2000409264 512-byte logical blocks: (1.02 TB/954 GiB)
[Thu Feb 29 09:11:40 2024] sd 9:0:0:0: [sdf] 4096-byte physical blocks
[Thu Feb 29 09:11:40 2024] sd 9:0:0:0: [sdf] Write Protect is off
[Thu Feb 29 09:11:40 2024] sd 9:0:0:0: [sdf] Mode Sense: 6b 00 00 08
[Thu Feb 29 09:11:40 2024] sd 9:0:0:0: [sdf] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
[Thu Feb 29 09:11:40 2024] sd 9:0:0:0: [sdf] Preferred minimum I/O size 4096 bytes
[Thu Feb 29 09:11:40 2024] sd 9:0:0:0: [sdf] Optimal transfer size 33553920 bytes not a multiple of preferred minimum block size (4096 bytes)
[Thu Feb 29 09:11:40 2024]  sdf: sdf1
[Thu Feb 29 09:11:40 2024] sd 9:0:0:0: [sdf] Attached SCSI disk
[Thu Feb 29 09:12:53 2024] ------------[ cut here ]------------
[Thu Feb 29 09:12:53 2024] WARNING: CPU: 0 PID: 3290 at block/blk-lib.c:50 __blkdev_issue_discard+0x13e/0x180
[Thu Feb 29 09:12:53 2024] Modules linked in: snd_seq_dummy snd_hrtimer snd_seq_midi snd_seq_midi_event snd_seq cpufreq_userspace cpufreq_conservative cpufreq_powersave cpufreq_ondemand cbc cts rpcsec_gss_krb5 nfsv4 dns_resolver nfs lockd grace fscache netfs scsi_transport_iscsi nvme_fabrics 
dell_rbu rfkill qrtr dcdbas uinput binfmt_misc nls_utf8 nls_cp437 vfat fat nvidia_drm(PO) nvidia_modeset(PO) intel_rapl_msr intel_rapl_common snd_hda_codec_realtek intel_uncore_frequency snd_hda_codec_generic ledtrig_audio intel_uncore_frequency_common x86_pkg_temp_thermal intel_powerclamp coretemp 
kvm_intel kvm snd_hda_codec_hdmi irqbypass mei_pxp mei_hdcp i915 snd_hda_intel rapl snd_intel_dspcfg snd_usb_audio cec snd_hda_codec snd_usbmidi_lib drm_buddy intel_cstate uvcvideo snd_hda_core snd_rawmidi videobuf2_vmalloc drm_display_helper snd_hwdep snd_seq_device uvc snd_pcm_oss videobuf2_memops 
ttm snd_mixer_oss videobuf2_v4l2 snd_pcm tpm_crb videodev drm_kms_helper tpm_tis snd_timer videobuf2_common evdev tpm_tis_core snd intel_gtt intel_uncore
[Thu Feb 29 09:12:53 2024]  wmi_bmof input_leds gigabyte_wmi pcspkr mc soundcore i2c_algo_bit tpm intel_hid rng_core sparse_keymap acpi_tad acpi_pad sg button mei_me mei nvidia(PO) bonding tls xt_recent br_netfilter overlay xt_comment xt_CHECKSUM nf_tables nfnetlink bridge 8021q garp stp mrp llc 
macvlan veth iptable_nat iptable_mangle iptable_filter ip6table_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ip6table_mangle ip6table_filter ip6_tables auth_rpcgss loop drm fuse efi_pstore agpgart configfs sunrpc ip_tables x_tables autofs4 ext4 crc16 mbcache jbd2 btrfs blake2b_generic 
efivarfs raid10 raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx xor raid6_pq libcrc32c crc32c_generic raid0 multipath linear hid_logitech_hidpp hid_logitech_dj uas usb_storage hid_generic usbhid hid cdc_ncm cdc_ether usbnet r8152 mii raid1 md_mod sd_mod dm_mod crct10dif_pclmul 
crc32_pclmul crc32c_intel polyval_clmulni polyval_generic gf128mul ghash_clmulni_intel sha512_ssse3 sha512_generic sha256_ssse3 sha1_ssse3
[Thu Feb 29 09:12:53 2024]  i2c_designware_platform i2c_designware_core nvme nvme_core t10_pi ahci xhci_pci crc64_rocksoft_generic aesni_intel crypto_simd r8169 libahci cryptd i2c_i801 crc64_rocksoft xhci_hcd i2c_smbus realtek crc64 libata intel_lpss_pci usbcore intel_lpss scsi_mod idma64 
scsi_common virt_dma usb_common fan video pinctrl_alderlake pinctrl_intel wmi pwm_lpss
[Thu Feb 29 09:12:53 2024] CPU: 0 PID: 3290 Comm: blkdiscard Tainted: P           O       6.7.6-raw #1
[Thu Feb 29 09:12:53 2024] Hardware name: Gigabyte Technology Co., Ltd. Z790 GAMING X/Z790 GAMING X, BIOS F9b 11/10/2023
[Thu Feb 29 09:12:53 2024] RIP: 0010:__blkdev_issue_discard+0x13e/0x180
[Thu Feb 29 09:12:53 2024] Code: 48 39 d8 75 91 f7 da 89 d3 c1 eb 09 eb 8b 48 8b 04 24 4c 89 20 48 83 c4 08 31 c0 5b 5d 41 5c 41 5d 41 5e 41 5f c3 cc cc cc cc <0f> 0b 48 c7 c6 00 26 e8 93 48 c7 c7 60 91 50 94 e8 3d 7a 5b 00 85
[Thu Feb 29 09:12:53 2024] RSP: 0018:ffffa7654119bd08 EFLAGS: 00010246
[Thu Feb 29 09:12:53 2024] RAX: ffff8d8f4c5be0b0 RBX: ffff8d8f4add3e80 RCX: ffff8d8f4add12c0
[Thu Feb 29 09:12:53 2024] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff8d8f4add3e80
[Thu Feb 29 09:12:53 2024] RBP: 0000000000000cc0 R08: ffffa7654119bd48 R09: 0000000000000000
[Thu Feb 29 09:12:53 2024] R10: 000000000000081c R11: 0000000000000000 R12: 0000000000000000
[Thu Feb 29 09:12:53 2024] R13: 00000000773bc800 R14: 000000ee77900000 R15: ffff8d8f4add3e80
[Thu Feb 29 09:12:53 2024] FS:  00007fb69dc57740(0000) GS:ffff8d9ebf400000(0000) knlGS:0000000000000000
[Thu Feb 29 09:12:53 2024] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[Thu Feb 29 09:12:53 2024] CR2: 00007ffefb8c6170 CR3: 000000017d8da000 CR4: 0000000000f50ef0
[Thu Feb 29 09:12:53 2024] PKRU: 55555554
[Thu Feb 29 09:12:53 2024] Call Trace:
[Thu Feb 29 09:12:53 2024]  <TASK>
[Thu Feb 29 09:12:53 2024]  ? __blkdev_issue_discard+0x13e/0x180
[Thu Feb 29 09:12:53 2024]  ? __warn+0x7c/0x130
[Thu Feb 29 09:12:53 2024]  ? __blkdev_issue_discard+0x13e/0x180
[Thu Feb 29 09:12:53 2024]  ? report_bug+0x191/0x1c0
[Thu Feb 29 09:12:53 2024]  ? handle_bug+0x3a/0x70
[Thu Feb 29 09:12:53 2024]  ? exc_invalid_op+0x17/0x70
[Thu Feb 29 09:12:53 2024]  ? asm_exc_invalid_op+0x1a/0x20
[Thu Feb 29 09:12:53 2024]  ? __blkdev_issue_discard+0x13e/0x180
[Thu Feb 29 09:12:53 2024]  blkdev_issue_discard+0x50/0xb0
[Thu Feb 29 09:12:53 2024]  blkdev_common_ioctl+0x820/0x970
[Thu Feb 29 09:12:53 2024]  ? do_fault+0x27c/0x690
[Thu Feb 29 09:12:53 2024]  blkdev_ioctl+0xc7/0x260
[Thu Feb 29 09:12:53 2024]  __x64_sys_ioctl+0x8f/0xd0
[Thu Feb 29 09:12:53 2024]  do_syscall_64+0x61/0x120
[Thu Feb 29 09:12:53 2024]  ? __count_memcg_events+0x6e/0xc0
[Thu Feb 29 09:12:53 2024]  ? handle_mm_fault+0xb0/0x370
[Thu Feb 29 09:12:53 2024]  ? __ct_user_enter+0x8d/0x100
[Thu Feb 29 09:12:53 2024]  entry_SYSCALL_64_after_hwframe+0x6e/0x76
[Thu Feb 29 09:12:53 2024] RIP: 0033:0x7fb69dd57c5b
[Thu Feb 29 09:12:53 2024] Code: 00 48 89 44 24 18 31 c0 48 8d 44 24 60 c7 04 24 10 00 00 00 48 89 44 24 08 48 8d 44 24 20 48 89 44 24 10 b8 10 00 00 00 0f 05 <89> c2 3d 00 f0 ff ff 77 1c 48 8b 44 24 18 64 48 2b 04 25 28 00 00
[Thu Feb 29 09:12:53 2024] RSP: 002b:00007ffefb889d70 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
[Thu Feb 29 09:12:53 2024] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fb69dd57c5b
[Thu Feb 29 09:12:53 2024] RDX: 00007ffefb889e30 RSI: 0000000000001277 RDI: 0000000000000003
[Thu Feb 29 09:12:53 2024] RBP: 0000000000000000 R08: 0000000000000007 R09: 000055b80fbd32f0
[Thu Feb 29 09:12:53 2024] R10: 00007ffefb889da0 R11: 0000000000000246 R12: 000000ee77900000
[Thu Feb 29 09:12:53 2024] R13: 0000000000000003 R14: 000055b80fbd32f0 R15: 0000000000000000
[Thu Feb 29 09:12:53 2024]  </TASK>
[Thu Feb 29 09:12:53 2024] ---[ end trace 0000000000000000 ]---
[Thu Feb 29 09:12:53 2024] sdf1: Error: discard_granularity is 0.
```

Re: RIP on discard, JMicron USB adaptor

[Martin K. Petersen]

Harald,

>> > I tried a discard on a Samsung PM981 1TB SSD (m.2) using a JMicron USB adaptor.
>> > 
>> > udev rule:
>> > 
>> > ACTION=="add|change", ATTRS{idVendor}=="152d",
>> > ATTRS{idProduct}=="0583", SUBSYSTEM=="scsi_disk",
>> > ATTR{provisioning_mode}="unmap"
>> > 
>> > Probably I was too optimistic.

> In the code comments above the WARN, this condition indicates "the
> discard granularity isn't set by buggy device driver". The block layer
> needs this set if your driver also sets the max_discard_sectors limit.

Please provide the output of:

# sg_readcap -l /dev/sdN
# sg_vpd -l /dev/sdN
# sg_vpd -p 0xb0 /dev/sdN
# sg_vpd -p 0xb1 /dev/sdN
# sg_vpd -p 0xb2 /dev/sdN
# sg_opcodes /dev/sdN

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: RIP on discard, JMicron USB adaptor

[Harald Dunkel]

Hi Martin,

On 2024-02-28 21:19:25, Martin K. Petersen wrote:
> 
>> In the code comments above the WARN, this condition indicates "the
>> discard granularity isn't set by buggy device driver". The block layer
>> needs this set if your driver also sets the max_discard_sectors limit.
> 
> Please provide the output of:
> 
> # sg_readcap -l /dev/sdN
> # sg_vpd -l /dev/sdN
> # sg_vpd -p 0xb0 /dev/sdN
> # sg_vpd -p 0xb1 /dev/sdN
> # sg_vpd -p 0xb2 /dev/sdN
> # sg_opcodes /dev/sdN
> 
> Thanks!
> 

I am not in the office anymore, so I cannot plugin the USB device to run
the commands you requested. First thing tomorrow in the morning, promised.


Regards

Harri

Re: RIP on discard, JMicron USB adaptor

[Harald Dunkel]

On 2024-02-28 21:19:25, Martin K. Petersen wrote:
> 
> Please provide the output of:
> 
 > # sg_readcap -l /dev/sdN
 > # sg_vpd -l /dev/sdN> # sg_vpd -p 0xb0 /dev/sdN
> # sg_vpd -p 0xb1 /dev/sdN
> # sg_vpd -p 0xb2 /dev/sdN
> # sg_opcodes /dev/sdN
> 
> Thanks!
> 

% sg_readcap -l /dev/sdf
Read Capacity results:
    Protection: prot_en=0, p_type=0, p_i_exponent=0
    Logical block provisioning: lbpme=0, lbprz=0
    Last LBA=2000409263 (0x773bd2af), Number of logical blocks=2000409264
    Logical block length=512 bytes
    Logical blocks per physical block exponent=3 [so physical block length=4096 bytes]
    Lowest aligned LBA=0
Hence:
    Device size: 1024209543168 bytes, 976762.3 MiB, 1024.21 GB

% sg_vpd -l /dev/sdf
Supported VPD pages VPD page:
    [PQual=0  Peripheral device type: disk]
   0x00  Supported VPD pages [sv]
   0x80  Unit serial number [sn]
   0x83  Device identification [di]
   0xb0  Block limits (SBC) [bl]
   0xb1  Block device characteristics (SBC) [bdc]
   0xb2  Logical block provisioning (SBC) [lbpv]
   0xde
   0xdf

% sg_vpd -p 0xb0 /dev/sdf
Block limits VPD page (SBC):
   Write same non-zero (WSNZ): 0
   Maximum compare and write length: 0 blocks [Command not implemented]
   Optimal transfer length granularity: 8 blocks
   Maximum transfer length: 65535 blocks
   Optimal transfer length: 65535 blocks
   Maximum prefetch transfer length: 65535 blocks
   Maximum unmap LBA count: -1 [unbounded]
   Maximum unmap block descriptor count: 63
   Optimal unmap granularity: 0 blocks [not reported]
   Unmap granularity alignment valid: false
   Unmap granularity alignment: 0 [invalid]
   Maximum write same length: 0 blocks [not reported]
   Maximum atomic transfer length: 0 blocks [not reported]
   Atomic alignment: 0 [unaligned atomic writes permitted]
   Atomic transfer length granularity: 0 [no granularity requirement
   Maximum atomic transfer length with atomic boundary: 0 blocks [not reported]
   Maximum atomic boundary size: 0 blocks [can only write atomic 1 block]

% sg_vpd -p 0xb1 /dev/sdf
Block device characteristics VPD page (SBC):
   Non-rotating medium (e.g. solid state)
   Product type: Not specified
   WABEREQ=0
   WACEREQ=0
   Nominal form factor not reported
   ZONED=0
   RBWZ=0
   BOCS=0
   FUAB=0
   VBULS=0
   DEPOPULATION_TIME=0 (seconds)

% sg_vpd -p 0xb2 /dev/sdf
Logical block provisioning VPD page (SBC):
   Unmap command supported (LBPU): 1
   Write same (16) with unmap bit supported (LBPWS): 0
   Write same (10) with unmap bit supported (LBPWS10): 0
   Logical block provisioning read zeros (LBPRZ): 0
   Anchored LBAs supported (ANC_SUP): 0
   Threshold exponent: 0 [threshold sets not supported]
   Descriptor present (DP): 0
   Minimum percentage: 0 [not reported]
   Provisioning type: 0 (not known or fully provisioned)
   Threshold percentage: 0 [percentages not supported]

% sg_opcodes /dev/sdf
   SAMSUNG   MZVLB1T0HALR      3108
   Peripheral device type: disk
Report supported operation codes: Illegal request, Invalid opcode


Hope this helps
Harri

Re: RIP on discard, JMicron USB adaptor

[Harald Dunkel]

Hi folks,

having some kind of feedback would be nice. Is this a known problem?
User error?

Of course I would be glad to help to track down this problem.

Regards
Harri

Re: RIP on discard, JMicron USB adaptor

[Martin K. Petersen]

Harald,

> having some kind of feedback would be nice. Is this a known problem?
> User error?
>
> Of course I would be glad to help to track down this problem.

Well, the device reports that block provisioning is disabled (lbpme=0)
which explains why discard is not enabled by default.

Oddly enough your device does not report an UNMAP granularity. I'm
trying to figure out how your discard granularity ends up being 0 given
that your device reports a physical block size of 4096.

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: RIP on discard, JMicron USB adaptor

[Harald Dunkel]

On 2024-03-05 03:14:24, Martin K. Petersen wrote:
> 
> Well, the device reports that block provisioning is disabled (lbpme=0)
> which explains why discard is not enabled by default.
> 
> Oddly enough your device does not report an UNMAP granularity. I'm
> trying to figure out how your discard granularity ends up being 0 given
> that your device reports a physical block size of 4096.
> 

I have inserted 2 other m.2 SSDs into the adapter: There was no problem
with these, esp there was no warning about discard_granularity, or a RIP.
First SSD back in: RIP is back, too. I would guess the first SSD is bad.

Sorry for all the trouble. I should have tried another m.2 SSD first.

Just for the record, this is what smartctl -x reports about the bad SSD:

-------------------------------------------------------------------------------
root@dpcl082:~# smartctl -x /dev/sdf
smartctl 7.4 2023-08-01 r5530 [x86_64-linux-6.7.6-raw] (local build)
Copyright (C) 2002-23, Bruce Allen, Christian Franke, www.smartmontools.org

=== START OF INFORMATION SECTION ===
Model Number:                       SAMSUNG MZVLB1T0HALR-000L7
Serial Number:                      S3TPNX0K917992
Firmware Version:                   5L2QEXA7
PCI Vendor/Subsystem ID:            0x144d
IEEE OUI Identifier:                0x002538
Total NVM Capacity:                 1,024,209,543,168 [1.02 TB]
Unallocated NVM Capacity:           0
Controller ID:                      4
NVMe Version:                       1.2
Number of Namespaces:               1
Namespace 1 Size/Capacity:          1,024,209,543,168 [1.02 TB]
Namespace 1 Utilization:            1,015,982,354,432 [1.01 TB]
Namespace 1 Formatted LBA Size:     512
Namespace 1 IEEE EUI-64:            002538 8981be5959
Local Time is:                      Tue Mar  5 08:29:01 2024 CET
Firmware Updates (0x16):            3 Slots, no Reset required
Optional Admin Commands (0x0017):   Security Format Frmw_DL Self_Test
Optional NVM Commands (0x001f):     Comp Wr_Unc DS_Mngmt Wr_Zero Sav/Sel_Feat
Log Page Attributes (0x03):         S/H_per_NS Cmd_Eff_Lg
Maximum Data Transfer Size:         512 Pages
Warning  Comp. Temp. Threshold:     81 Celsius
Critical Comp. Temp. Threshold:     82 Celsius

Supported Power States
St Op     Max   Active     Idle   RL RT WL WT  Ent_Lat  Ex_Lat
  0 +     7.02W       -        -    0  0  0  0        0       0
  1 +     6.30W       -        -    1  1  1  1        0       0
  2 +     3.50W       -        -    2  2  2  2        0       0
  3 -   0.0760W       -        -    3  3  3  3      210    1200
  4 -   0.0050W       -        -    4  4  4  4     2000    8000

Supported LBA Sizes (NSID 0x1)
Id Fmt  Data  Metadt  Rel_Perf
  0 +     512       0         0

=== START OF SMART DATA SECTION ===
SMART overall-health self-assessment test result: PASSED

SMART/Health Information (NVMe Log 0x02)
Critical Warning:                   0x00
Temperature:                        24 Celsius
Available Spare:                    100%
Available Spare Threshold:          10%
Percentage Used:                    4%
Data Units Read:                    32,373,823 [16.5 TB]
Data Units Written:                 59,721,865 [30.5 TB]
Host Read Commands:                 848,557,454
Host Write Commands:                1,025,191,828
Controller Busy Time:               2,700
Power Cycles:                       2,222
Power On Hours:                     5,568
Unsafe Shutdowns:                   666
Media and Data Integrity Errors:    0
Error Information Log Entries:      3,607
Warning  Comp. Temperature Time:    0
Critical Comp. Temperature Time:    0
Temperature Sensor 1:               24 Celsius
Temperature Sensor 2:               25 Celsius

Error Information (NVMe Log 0x01, 16 of 64 entries)
No Errors Logged

Self-test Log (NVMe Log 0x06)
Self-test status: No self-test in progress
No Self-tests Logged
-------------------------------------------------------------------------------

Regards
Harri