From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>
Subject: Re: [PATCH 1/2] block: open code __blk_account_io_start()
Date: Mon, 27 Mar 2023 22:23:37 +0000 [thread overview]
Message-ID: <a021767b-bccf-be63-9cdf-ec0db42cace0@nvidia.com> (raw)
In-Reply-To: <ZCIUtZGOaxIza3j3@infradead.org>
On 3/27/23 15:12, Christoph Hellwig wrote:
> On Mon, Mar 27, 2023 at 12:34:26AM -0700, Chaitanya Kulkarni wrote:
>> There is only one caller for __blk_account_io_start(), the function
>> is small enough to fit in its caller blk_account_io_start().
>>
>> Remove the function and opencode in the its caller
>> blk_account_io_start().
> Having the account slow path in a separate function actually is nice,
> same for the next patch.
>
>> + /*
>> + * All non-passthrough requests are created from a bio with one
>> + * exception: when a flush command that is part of a flush sequence
>> + * generated by the state machine in blk-flush.c is cloned onto the
>> + * lower device by dm-multipath we can get here without a bio.
>> + */
> ... and now you've created a totally messed up block comment expanding
> over 80 characters.
ohh, checkpatch didn't spit out any warning [1].
-ck
[1]
-----------------------------------------------------------------------
p/blk-account-cleanup/0001-block-open-code-__blk_account_io_start.patch
-----------------------------------------------------------------------
total: 0 errors, 0 warnings, 44 lines checked
p/blk-account-cleanup/0001-block-open-code-__blk_account_io_start.patch
has no obvious style problems and is ready for submission.
----------------------------------------------------------------------
p/blk-account-cleanup/0002-block-open-code-__blk_account_io_done.patch
----------------------------------------------------------------------
total: 0 errors, 0 warnings, 34 lines checked
p/blk-account-cleanup/0002-block-open-code-__blk_account_io_done.patch
has no obvious style problems and is ready for submission.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
next prev parent reply other threads:[~2023-03-27 22:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 7:34 [PATCH 0/2] block: remove unnecessary helpers Chaitanya Kulkarni
2023-03-27 7:34 ` [PATCH 1/2] block: open code __blk_account_io_start() Chaitanya Kulkarni
2023-03-27 22:12 ` Christoph Hellwig
2023-03-27 22:23 ` Chaitanya Kulkarni [this message]
2023-03-27 22:43 ` Jens Axboe
2023-03-27 7:34 ` [PATCH 2/2] block: open code __blk_account_io_done() Chaitanya Kulkarni
2023-03-27 19:23 ` [PATCH 0/2] block: remove unnecessary helpers Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a021767b-bccf-be63-9cdf-ec0db42cace0@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox