From: Christoph Hellwig <hch@infradead.org>
To: Chaitanya Kulkarni <kch@nvidia.com>
Cc: linux-block@vger.kernel.org, axboe@kernel.dk
Subject: Re: [PATCH 1/2] block: open code __blk_account_io_start()
Date: Mon, 27 Mar 2023 15:12:05 -0700 [thread overview]
Message-ID: <ZCIUtZGOaxIza3j3@infradead.org> (raw)
In-Reply-To: <20230327073427.4403-2-kch@nvidia.com>
On Mon, Mar 27, 2023 at 12:34:26AM -0700, Chaitanya Kulkarni wrote:
> There is only one caller for __blk_account_io_start(), the function
> is small enough to fit in its caller blk_account_io_start().
>
> Remove the function and opencode in the its caller
> blk_account_io_start().
Having the account slow path in a separate function actually is nice,
same for the next patch.
> + /*
> + * All non-passthrough requests are created from a bio with one
> + * exception: when a flush command that is part of a flush sequence
> + * generated by the state machine in blk-flush.c is cloned onto the
> + * lower device by dm-multipath we can get here without a bio.
> + */
... and now you've created a totally messed up block comment expanding
over 80 characters.
next prev parent reply other threads:[~2023-03-27 22:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 7:34 [PATCH 0/2] block: remove unnecessary helpers Chaitanya Kulkarni
2023-03-27 7:34 ` [PATCH 1/2] block: open code __blk_account_io_start() Chaitanya Kulkarni
2023-03-27 22:12 ` Christoph Hellwig [this message]
2023-03-27 22:23 ` Chaitanya Kulkarni
2023-03-27 22:43 ` Jens Axboe
2023-03-27 7:34 ` [PATCH 2/2] block: open code __blk_account_io_done() Chaitanya Kulkarni
2023-03-27 19:23 ` [PATCH 0/2] block: remove unnecessary helpers Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCIUtZGOaxIza3j3@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox