From: Nilay Shroff <nilay@linux.ibm.com>
To: Zizhi Wo <wozizhi@huaweicloud.com>,
axboe@kernel.dk, dlemoal@kernel.org, kch@nvidia.com,
johannes.thumshirn@wdc.com, kbusch@kernel.org,
bvanassche@acm.org, linux-block@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, yangerkun@huawei.com,
chengzhihao1@huawei.com, wozizhi@huawei.com
Subject: Re: [PATCH V4 2/9] null_blk: register configfs subsystem after creating default devices
Date: Fri, 10 Jul 2026 18:06:12 +0530 [thread overview]
Message-ID: <a0af6e54-9cc7-4f9e-8a13-8dc33c166514@linux.ibm.com> (raw)
In-Reply-To: <20260709100452.3520482-3-wozizhi@huaweicloud.com>
On 7/9/26 3:34 PM, Zizhi Wo wrote:
> In null_init(), configfs_register_subsystem() currently runs before
> register_blkdev(), so when null_blk is built as a module, a racing mkdir()
> + poweron from userspace can reach null_add_dev() while null_major is still
> 0. __add_disk() then hits WARN_ON(disk->minors) (major=0 with minors!=0)
> and fails:
Looks good to me.
Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
next prev parent reply other threads:[~2026-07-10 12:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 10:04 [PATCH V4 0/9] null_blk: fix init/exit races and memleaks Zizhi Wo
2026-07-09 10:04 ` [PATCH V4 1/9] null_blk: use DEFINE_MUTEX for the file-scope mutex Zizhi Wo
2026-07-10 12:35 ` Nilay Shroff
2026-07-09 10:04 ` [PATCH V4 2/9] null_blk: register configfs subsystem after creating default devices Zizhi Wo
2026-07-10 12:36 ` Nilay Shroff [this message]
2026-07-09 10:04 ` [PATCH V4 3/9] null_blk: move unregister_blkdev() after destroying dev in null_exit() Zizhi Wo
2026-07-10 12:36 ` Nilay Shroff
2026-07-09 10:04 ` [PATCH V4 4/9] null_blk: free global tag_set on init error path Zizhi Wo
2026-07-10 12:37 ` Nilay Shroff
2026-07-09 10:04 ` [PATCH V4 5/9] null_blk: free zones array on device power-off Zizhi Wo
2026-07-09 10:04 ` [PATCH V4 6/9] null_blk: clean up null_del_dev() to use cached dev pointer Zizhi Wo
2026-07-10 13:03 ` Nilay Shroff
2026-07-09 10:04 ` [PATCH V4 7/9] null_blk: reject per-device queue resize for shared tag set Zizhi Wo
2026-07-10 12:34 ` Nilay Shroff
2026-07-09 10:04 ` [PATCH V4 8/9] null_blk: serialize configfs attribute stores with device setup Zizhi Wo
2026-07-10 12:30 ` Nilay Shroff
2026-07-09 10:04 ` [PATCH V4 9/9] null_blk: serialize configfs attribute shows with the file-scope lock Zizhi Wo
2026-07-10 12:31 ` Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0af6e54-9cc7-4f9e-8a13-8dc33c166514@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chengzhihao1@huawei.com \
--cc=dlemoal@kernel.org \
--cc=johannes.thumshirn@wdc.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wozizhi@huawei.com \
--cc=wozizhi@huaweicloud.com \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox