From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Yu Kuai <yukuai1@huaweicloud.com>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 5/5] brd: use memcpy_{to,from]_page in brd_rw_bvec
Date: Tue, 22 Apr 2025 11:30:42 +0200 [thread overview]
Message-ID: <a7b3b9dd-f7ad-4bbb-a119-21bc5c2033be@suse.de> (raw)
In-Reply-To: <20250421072641.1311040-6-hch@lst.de>
On 4/21/25 09:26, Christoph Hellwig wrote:
> Use the proper helpers to copy to/from potential highmem pages, which
> do a local instead of atomic kmap underneath, and perform
> flush_dcache_page where needed. This also simplifies the code so much
> that the separate read write helpers are not required any more.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/block/brd.c | 57 ++++++++++-----------------------------------
> 1 file changed, 12 insertions(+), 45 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
next prev parent reply other threads:[~2025-04-22 9:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 7:26 brd cleanups Christoph Hellwig
2025-04-21 7:26 ` [PATCH 1/5] brd; pass a bvec pointer to brd_do_bvec Christoph Hellwig
2025-04-22 6:36 ` Yu Kuai
2025-04-22 9:24 ` Hannes Reinecke
2025-04-28 9:21 ` Johannes Thumshirn
2025-04-21 7:26 ` [PATCH 2/5] brd: remove the sector variable in brd_submit_bio Christoph Hellwig
2025-04-22 6:38 ` Yu Kuai
2025-04-22 9:24 ` Hannes Reinecke
2025-04-21 7:26 ` [PATCH 3/5] brd: use bvec_kmap_local in brd_do_bvec Christoph Hellwig
2025-04-22 6:42 ` Yu Kuai
2025-04-22 9:25 ` Hannes Reinecke
2025-04-21 7:26 ` [PATCH 4/5] brd: split I/O at page boundaries Christoph Hellwig
2025-04-22 9:30 ` Hannes Reinecke
2025-04-22 11:10 ` Yu Kuai
2025-04-21 7:26 ` [PATCH 5/5] brd: use memcpy_{to,from]_page in brd_rw_bvec Christoph Hellwig
2025-04-22 9:30 ` Hannes Reinecke [this message]
2025-04-22 11:18 ` Yu Kuai
2025-04-22 13:50 ` Christoph Hellwig
2025-04-23 3:26 ` Yu Kuai
-- strict thread matches above, loose matches on Subject: below --
2025-04-28 14:09 brd cleanups v2 Christoph Hellwig
2025-04-28 14:09 ` [PATCH 5/5] brd: use memcpy_{to,from]_page in brd_rw_bvec Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7b3b9dd-f7ad-4bbb-a119-21bc5c2033be@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox