From: Logan Gunthorpe <logang@deltatee.com>
To: Daniel Wagner <dwagner@suse.de>, linux-block@vger.kernel.org
Cc: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH blktests] nvme/018: Ignore message generated by nvme read
Date: Mon, 27 Jan 2020 10:03:47 -0700 [thread overview]
Message-ID: <a84f53ab-3f76-df73-e9f7-fb57c03eeb2d@deltatee.com> (raw)
In-Reply-To: <20200127145353.52129-1-dwagner@suse.de>
On 2020-01-27 7:53 a.m., Daniel Wagner wrote:
> nvme-cli writes 'CAP_EXCEEDED' message also on stdout not just
> stderr. This lets the test fail as well.
>
> Fixes: 1aee5f430b30 ("nvme/018: Ignore error message generated by nvme read")
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> tests/nvme/018 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/nvme/018 b/tests/nvme/018
> index 0a5b4c2ab019..d0f15db23538 100755
> --- a/tests/nvme/018
> +++ b/tests/nvme/018
> @@ -43,7 +43,7 @@ test() {
> sectors="$(blockdev --getsz "/dev/${nvmedev}n1")"
> bs="$(blockdev --getbsz "/dev/${nvmedev}n1")"
>
> - nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" 2>"$FULL" \
> + nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" &>"$FULL" \
> && echo "ERROR: Successfully read out of device lba range"
That's an odd message for an error... Error! I succeeded!
> nvme disconnect -n "${subsys_name}"
>
next prev parent reply other threads:[~2020-01-27 17:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 14:53 [PATCH blktests] nvme/018: Ignore message generated by nvme read Daniel Wagner
2020-01-27 17:03 ` Logan Gunthorpe [this message]
2020-01-27 17:38 ` Daniel Wagner
2020-01-28 0:05 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a84f53ab-3f76-df73-e9f7-fb57c03eeb2d@deltatee.com \
--to=logang@deltatee.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=dwagner@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox