public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Wagner <dwagner@suse.de>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-block@vger.kernel.org,
	Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
	Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH blktests] nvme/018: Ignore message generated by nvme read
Date: Mon, 27 Jan 2020 18:38:45 +0100	[thread overview]
Message-ID: <20200127173845.5kbzrix524bmwwa6@beryllium.lan> (raw)
In-Reply-To: <a84f53ab-3f76-df73-e9f7-fb57c03eeb2d@deltatee.com>

On Mon, Jan 27, 2020 at 10:03:47AM -0700, Logan Gunthorpe wrote:
> > -	nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" 2>"$FULL" \
> > +	nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" &>"$FULL" \
> >  		&& echo "ERROR: Successfully read out of device lba range"
> 
> That's an odd message for an error... Error! I succeeded!

I think the idea is that the command should *not* succeed. So 'nvme
read' is expected to fail.

It is a bit confusing. What about something like

"ERROR: lba range read was unexpected successfull"?



  reply	other threads:[~2020-01-27 17:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-27 14:53 [PATCH blktests] nvme/018: Ignore message generated by nvme read Daniel Wagner
2020-01-27 17:03 ` Logan Gunthorpe
2020-01-27 17:38   ` Daniel Wagner [this message]
2020-01-28  0:05     ` Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200127173845.5kbzrix524bmwwa6@beryllium.lan \
    --to=dwagner@suse.de \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=linux-block@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=osandov@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox