* [PATCH blktests] nvme/018: Ignore message generated by nvme read
@ 2020-01-27 14:53 Daniel Wagner
2020-01-27 17:03 ` Logan Gunthorpe
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Wagner @ 2020-01-27 14:53 UTC (permalink / raw)
To: linux-block
Cc: Johannes Thumshirn, Logan Gunthorpe, Omar Sandoval, Daniel Wagner
nvme-cli writes 'CAP_EXCEEDED' message also on stdout not just
stderr. This lets the test fail as well.
Fixes: 1aee5f430b30 ("nvme/018: Ignore error message generated by nvme read")
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
tests/nvme/018 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/nvme/018 b/tests/nvme/018
index 0a5b4c2ab019..d0f15db23538 100755
--- a/tests/nvme/018
+++ b/tests/nvme/018
@@ -43,7 +43,7 @@ test() {
sectors="$(blockdev --getsz "/dev/${nvmedev}n1")"
bs="$(blockdev --getbsz "/dev/${nvmedev}n1")"
- nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" 2>"$FULL" \
+ nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" &>"$FULL" \
&& echo "ERROR: Successfully read out of device lba range"
nvme disconnect -n "${subsys_name}"
--
2.16.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH blktests] nvme/018: Ignore message generated by nvme read
2020-01-27 14:53 [PATCH blktests] nvme/018: Ignore message generated by nvme read Daniel Wagner
@ 2020-01-27 17:03 ` Logan Gunthorpe
2020-01-27 17:38 ` Daniel Wagner
0 siblings, 1 reply; 4+ messages in thread
From: Logan Gunthorpe @ 2020-01-27 17:03 UTC (permalink / raw)
To: Daniel Wagner, linux-block; +Cc: Johannes Thumshirn, Omar Sandoval
On 2020-01-27 7:53 a.m., Daniel Wagner wrote:
> nvme-cli writes 'CAP_EXCEEDED' message also on stdout not just
> stderr. This lets the test fail as well.
>
> Fixes: 1aee5f430b30 ("nvme/018: Ignore error message generated by nvme read")
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> tests/nvme/018 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/nvme/018 b/tests/nvme/018
> index 0a5b4c2ab019..d0f15db23538 100755
> --- a/tests/nvme/018
> +++ b/tests/nvme/018
> @@ -43,7 +43,7 @@ test() {
> sectors="$(blockdev --getsz "/dev/${nvmedev}n1")"
> bs="$(blockdev --getbsz "/dev/${nvmedev}n1")"
>
> - nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" 2>"$FULL" \
> + nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" &>"$FULL" \
> && echo "ERROR: Successfully read out of device lba range"
That's an odd message for an error... Error! I succeeded!
> nvme disconnect -n "${subsys_name}"
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH blktests] nvme/018: Ignore message generated by nvme read
2020-01-27 17:03 ` Logan Gunthorpe
@ 2020-01-27 17:38 ` Daniel Wagner
2020-01-28 0:05 ` Chaitanya Kulkarni
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Wagner @ 2020-01-27 17:38 UTC (permalink / raw)
To: Logan Gunthorpe; +Cc: linux-block, Johannes Thumshirn, Omar Sandoval
On Mon, Jan 27, 2020 at 10:03:47AM -0700, Logan Gunthorpe wrote:
> > - nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" 2>"$FULL" \
> > + nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" &>"$FULL" \
> > && echo "ERROR: Successfully read out of device lba range"
>
> That's an odd message for an error... Error! I succeeded!
I think the idea is that the command should *not* succeed. So 'nvme
read' is expected to fail.
It is a bit confusing. What about something like
"ERROR: lba range read was unexpected successfull"?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH blktests] nvme/018: Ignore message generated by nvme read
2020-01-27 17:38 ` Daniel Wagner
@ 2020-01-28 0:05 ` Chaitanya Kulkarni
0 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2020-01-28 0:05 UTC (permalink / raw)
To: Daniel Wagner, Logan Gunthorpe
Cc: linux-block@vger.kernel.org, Johannes Thumshirn, Omar Sandoval
On 01/27/2020 09:38 AM, Daniel Wagner wrote:
> "ERROR: lba range read was unexpected successfull"?
nit :- s/successfull/successful/
How about ?
"ERROR: nvme read was successful for out of range lba" ?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-28 0:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-27 14:53 [PATCH blktests] nvme/018: Ignore message generated by nvme read Daniel Wagner
2020-01-27 17:03 ` Logan Gunthorpe
2020-01-27 17:38 ` Daniel Wagner
2020-01-28 0:05 ` Chaitanya Kulkarni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox