[PATCH] zloop: explicitly mention full zone when writing to it

[PATCH] zloop: explicitly mention full zone when writing to it

[Christoph Hellwig]

Don't print the impossibly large write pointer, but directly mention
the full zone when a write to one is received.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/zloop.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/block/zloop.c b/drivers/block/zloop.c
index 394dc2408ed7..f8988f9b5d04 100644
--- a/drivers/block/zloop.c
+++ b/drivers/block/zloop.c
@@ -603,8 +603,12 @@ static int zloop_seq_write_prep(struct zloop_cmd *cmd)
 		}
 	} else {
 		if (cmd->sector != zone->wp) {
-			pr_err("Zone %u: unaligned write: sect %llu, wp %llu\n",
-			       zone_no, cmd->sector, zone->wp);
+			if (zone->wp == ULLONG_MAX)
+				pr_err("Zone %u: write to full zone: sect %llu\n",
+				       zone_no, cmd->sector);
+			else
+				pr_err("Zone %u: unaligned write: sect %llu, wp %llu\n",
+				       zone_no, cmd->sector, zone->wp);
 			ret = -EIO;
 			goto out_unlock;
 		}
-- 
2.53.0

Re: [PATCH] zloop: explicitly mention full zone when writing to it

[Damien Le Moal]

On 2026/10/12 15:25, Christoph Hellwig wrote:
> Don't print the impossibly large write pointer, but directly mention
> the full zone when a write to one is received.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/block/zloop.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/block/zloop.c b/drivers/block/zloop.c
> index 394dc2408ed7..f8988f9b5d04 100644
> --- a/drivers/block/zloop.c
> +++ b/drivers/block/zloop.c
> @@ -603,8 +603,12 @@ static int zloop_seq_write_prep(struct zloop_cmd *cmd)
>  		}
>  	} else {
>  		if (cmd->sector != zone->wp) {
> -			pr_err("Zone %u: unaligned write: sect %llu, wp %llu\n",
> -			       zone_no, cmd->sector, zone->wp);
> +			if (zone->wp == ULLONG_MAX)

ULLONG_MAX is used also for reporting the write pointer of read-only and offline
zones. So maybe we should mention the condition here using blk_zone_cond_str()
instead of hard coding "full" in the message.

> +				pr_err("Zone %u: write to full zone: sect %llu\n",
> +				       zone_no, cmd->sector);

				pr_err("Zone %u: write to %s zone: sect %llu\n",
				       zone_no, blk_zone_cond_str(zone->cond),
				       cmd->sector);

> +			else
> +				pr_err("Zone %u: unaligned write: sect %llu, wp %llu\n",
> +				       zone_no, cmd->sector, zone->wp);
>  			ret = -EIO;
>  			goto out_unlock;
>  		}


-- 
Damien Le Moal
Western Digital Research