public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Jackie Liu <liu.yun@linux.dev>, "axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] n64cart: convert bi_disk to bi_bdev->bd_disk fix build
Date: Mon, 21 Mar 2022 07:22:55 +0000	[thread overview]
Message-ID: <af81b502-a5ae-b215-71f3-64eeba8774af@nvidia.com> (raw)
In-Reply-To: <20220321071216.1549596-1-liu.yun@linux.dev>

On 3/21/22 00:12, Jackie Liu wrote:
> From: Jackie Liu <liuyun01@kylinos.cn>
> 
> My kernel robot report below:
> 
>    drivers/block/n64cart.c: In function ‘n64cart_submit_bio’:
>    drivers/block/n64cart.c:91:26: error: ‘struct bio’ has no member named ‘bi_disk’
>       91 |  struct device *dev = bio->bi_disk->private_data;
>          |                          ^~
>      CC      drivers/slimbus/qcom-ctrl.o
>      CC      drivers/auxdisplay/hd44780.o
>      CC      drivers/watchdog/watchdog_core.o
>      CC      drivers/nvme/host/fault_inject.o
>      AR      drivers/accessibility/braille/built-in.a
>    make[2]: *** [scripts/Makefile.build:288: drivers/block/n64cart.o] Error 1
> 
> Fixes: 309dca309fc3 ("block: store a block_device pointer in struct bio");
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck



  reply	other threads:[~2022-03-21  7:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-21  7:12 [PATCH] n64cart: convert bi_disk to bi_bdev->bd_disk fix build Jackie Liu
2022-03-21  7:22 ` Chaitanya Kulkarni [this message]
2022-03-21 12:35 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af81b502-a5ae-b215-71f3-64eeba8774af@nvidia.com \
    --to=chaitanyak@nvidia.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=liu.yun@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox