* [PATCH] n64cart: convert bi_disk to bi_bdev->bd_disk fix build
@ 2022-03-21 7:12 Jackie Liu
2022-03-21 7:22 ` Chaitanya Kulkarni
2022-03-21 12:35 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Jackie Liu @ 2022-03-21 7:12 UTC (permalink / raw)
To: axboe; +Cc: linux-block
From: Jackie Liu <liuyun01@kylinos.cn>
My kernel robot report below:
drivers/block/n64cart.c: In function ‘n64cart_submit_bio’:
drivers/block/n64cart.c:91:26: error: ‘struct bio’ has no member named ‘bi_disk’
91 | struct device *dev = bio->bi_disk->private_data;
| ^~
CC drivers/slimbus/qcom-ctrl.o
CC drivers/auxdisplay/hd44780.o
CC drivers/watchdog/watchdog_core.o
CC drivers/nvme/host/fault_inject.o
AR drivers/accessibility/braille/built-in.a
make[2]: *** [scripts/Makefile.build:288: drivers/block/n64cart.o] Error 1
Fixes: 309dca309fc3 ("block: store a block_device pointer in struct bio");
Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
---
drivers/block/n64cart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/n64cart.c b/drivers/block/n64cart.c
index 4db9a8c244af..e094d2b8b5a9 100644
--- a/drivers/block/n64cart.c
+++ b/drivers/block/n64cart.c
@@ -88,7 +88,7 @@ static void n64cart_submit_bio(struct bio *bio)
{
struct bio_vec bvec;
struct bvec_iter iter;
- struct device *dev = bio->bi_disk->private_data;
+ struct device *dev = bio->bi_bdev->bd_disk->private_data;
u32 pos = bio->bi_iter.bi_sector << SECTOR_SHIFT;
bio_for_each_segment(bvec, bio, iter) {
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] n64cart: convert bi_disk to bi_bdev->bd_disk fix build
2022-03-21 7:12 [PATCH] n64cart: convert bi_disk to bi_bdev->bd_disk fix build Jackie Liu
@ 2022-03-21 7:22 ` Chaitanya Kulkarni
2022-03-21 12:35 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2022-03-21 7:22 UTC (permalink / raw)
To: Jackie Liu, axboe@kernel.dk; +Cc: linux-block@vger.kernel.org
On 3/21/22 00:12, Jackie Liu wrote:
> From: Jackie Liu <liuyun01@kylinos.cn>
>
> My kernel robot report below:
>
> drivers/block/n64cart.c: In function ‘n64cart_submit_bio’:
> drivers/block/n64cart.c:91:26: error: ‘struct bio’ has no member named ‘bi_disk’
> 91 | struct device *dev = bio->bi_disk->private_data;
> | ^~
> CC drivers/slimbus/qcom-ctrl.o
> CC drivers/auxdisplay/hd44780.o
> CC drivers/watchdog/watchdog_core.o
> CC drivers/nvme/host/fault_inject.o
> AR drivers/accessibility/braille/built-in.a
> make[2]: *** [scripts/Makefile.build:288: drivers/block/n64cart.o] Error 1
>
> Fixes: 309dca309fc3 ("block: store a block_device pointer in struct bio");
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] n64cart: convert bi_disk to bi_bdev->bd_disk fix build
2022-03-21 7:12 [PATCH] n64cart: convert bi_disk to bi_bdev->bd_disk fix build Jackie Liu
2022-03-21 7:22 ` Chaitanya Kulkarni
@ 2022-03-21 12:35 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2022-03-21 12:35 UTC (permalink / raw)
To: Jackie Liu; +Cc: linux-block
On Mon, 21 Mar 2022 15:12:16 +0800, Jackie Liu wrote:
> From: Jackie Liu <liuyun01@kylinos.cn>
>
> My kernel robot report below:
>
> drivers/block/n64cart.c: In function ‘n64cart_submit_bio’:
> drivers/block/n64cart.c:91:26: error: ‘struct bio’ has no member named ‘bi_disk’
> 91 | struct device *dev = bio->bi_disk->private_data;
> | ^~
> CC drivers/slimbus/qcom-ctrl.o
> CC drivers/auxdisplay/hd44780.o
> CC drivers/watchdog/watchdog_core.o
> CC drivers/nvme/host/fault_inject.o
> AR drivers/accessibility/braille/built-in.a
> make[2]: *** [scripts/Makefile.build:288: drivers/block/n64cart.o] Error 1
>
> [...]
Applied, thanks!
[1/1] n64cart: convert bi_disk to bi_bdev->bd_disk fix build
commit: b2479de38d8fc7ef13d5c78ff5ded6e5a1a4eac0
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-21 12:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-21 7:12 [PATCH] n64cart: convert bi_disk to bi_bdev->bd_disk fix build Jackie Liu
2022-03-21 7:22 ` Chaitanya Kulkarni
2022-03-21 12:35 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox