Re: [PATCH blktests] block/044: basic block error injection sanity test

[Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>]

On Jun 25, 2026 / 13:54, Christoph Hellwig wrote:
> On Thu, Jun 25, 2026 at 03:36:19PM +0900, Shin'ichiro Kawasaki wrote:
> > Hi Christoph, thanks for the patch. I ran the test case with block/for-next
> > kernel branch tip and confirmed that it is working as expected.
> > 
> > Please find my comments in line. FYI, I atttach the patch which reflects my
> > comments. If you are fine with the changes, please let me know so that I can
> > fold in the change and apply this patch.
> 
> > > +# SPDX-License-Identifier: GPL-2.0
> > 
> > Nit: Majority of the blktests test cases have GPL-3.0+. If you do not mind,
> > I suggest GPL-3.0+.
> 
> Well a mix of licenses is obviously bad, although I hate the GPL 3 with
> passion.

I see, I respoect author's choice.

> 
> > I suggest to add the line below.
> > 
> >        _have_kernel_option BLK_ERROR_INJECTION
> > 
> > This way, we can confirm the kernel has the required changes and
> > the dependent feature is enabled.
> 
> Sounds good, although this assumes we actually have /proc/config.gz?

Blktests checks both /proc/config.gz and /boot/config-$(uname -r), then I
think this to work on all test systems.

> 
> Otherwise the changes looks fine.