* [PATCH blktests] README.md, check: require getconf
@ 2026-06-24 7:18 Shin'ichiro Kawasaki
2026-07-06 2:53 ` Shin'ichiro Kawasaki
0 siblings, 1 reply; 2+ messages in thread
From: Shin'ichiro Kawasaki @ 2026-06-24 7:18 UTC (permalink / raw)
To: linux-block
Cc: Omar Sandoval, Chaitanya Kulkarni, Bart Van Assche, Jeff Moyer,
Shin'ichiro Kawasaki
Some test cases use the getconf command to query the page size that the
kernel supports (e.g. scsi/011, throtl/{002,003,007}, zbd/{010,014}).
Add getconf to the list of required commands so its absence is reported
clearly, and document it as a dependency in README.md.
Link: https://lore.kernel.org/linux-block/ajm1x0koQ4BftBOc@shinmob/
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
---
README.md | 1 +
check | 1 +
2 files changed, 2 insertions(+)
diff --git a/README.md b/README.md
index b137a43..b62540a 100644
--- a/README.md
+++ b/README.md
@@ -19,6 +19,7 @@ The dependencies are minimal, but make sure you have them installed:
- fio
- gcc
- make
+- getconf
- systemd-udev (udevadm)
Some tests require the following:
diff --git a/check b/check
index a68049b..bc2dde9 100755
--- a/check
+++ b/check
@@ -1118,6 +1118,7 @@ _check_dependencies() {
required_commands_and_packages[blockdev]="util-linux"
required_commands_and_packages[fio]="fio"
required_commands_and_packages[udevadm]="systemd-udev"
+ required_commands_and_packages[getconf]="glibc-common or libc-bin"
for cmd in "${!required_commands_and_packages[@]}"; do
command -v "$cmd" &> /dev/null && continue
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH blktests] README.md, check: require getconf
2026-06-24 7:18 [PATCH blktests] README.md, check: require getconf Shin'ichiro Kawasaki
@ 2026-07-06 2:53 ` Shin'ichiro Kawasaki
0 siblings, 0 replies; 2+ messages in thread
From: Shin'ichiro Kawasaki @ 2026-07-06 2:53 UTC (permalink / raw)
To: linux-block
Cc: Omar Sandoval, Chaitanya Kulkarni, Bart Van Assche, Jeff Moyer
On Jun 24, 2026 / 16:18, Shin'ichiro Kawasaki wrote:
> Some test cases use the getconf command to query the page size that the
> kernel supports (e.g. scsi/011, throtl/{002,003,007}, zbd/{010,014}).
> Add getconf to the list of required commands so its absence is reported
> clearly, and document it as a dependency in README.md.
>
> Link: https://lore.kernel.org/linux-block/ajm1x0koQ4BftBOc@shinmob/
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
FYI, I applied this patch.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-06 2:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-24 7:18 [PATCH blktests] README.md, check: require getconf Shin'ichiro Kawasaki
2026-07-06 2:53 ` Shin'ichiro Kawasaki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox