Linux block layer
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Chris S <coshi036@gmail.com>
Cc: Keith Busch <kbusch@meta.com>,
	linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	axboe@kernel.dk, hch@lst.de, tom.leiming@gmail.com,
	Igor.Achkinazi@dell.com, dlemoal@kernel.org,
	Weidong Zhu <weizhu@fiu.edu>
Subject: Re: [PATCH RFC 3/5] block: validate bio bounds in the queue entered context
Date: Mon, 10 Aug 2026 15:23:13 -0600	[thread overview]
Message-ID: <anpBQXfo7eGNU2-v@kbusch-mbp> (raw)
In-Reply-To: <CACd_6n2jNS9Msd_N-idPx3ijgN8NUxT1U1m2OrJu=e+GToB+ZA@mail.gmail.com>

On Mon, Aug 10, 2026 at 05:12:45PM -0400, Chris S wrote:
> Keith, I checked this patch against the nvme_setup_rw() WARN I reported
> (the second link in your cover letter).  __bio_split_to_limits() is
> called from blk_mq_submit_bio() after bio_queue_enter(), on both the
> cached-request path and the newly-allocated-request path, so the bounds
> check is now serialized against the freeze window in
> nvme_update_ns_info_block().  With the capacity forced to 0, the bio is
> failed here and can no longer reach nvme_queue_rq(), which is exactly
> the race I hit.  Thanks for picking it up, and sorry for the slow reply.
> 
> I'll drop my own "nvme: don't WARN on I/O to a namespace revalidated to
> unusable metadata" patch in favour of this.

I'll need to revisit this approach as it is dependent on something in
the stack calling the split to limits functions, as well as the upper
layers error handling for a catching the end-of-device condition later
than before.

  reply	other threads:[~2026-08-10 21:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 17:23 [PATCH RFC 0/5] block: validate bios against queue limits in the entered context Keith Busch
2026-05-19 17:23 ` [PATCH RFC 1/5] blk-mq: fix status for unaligned bio Keith Busch
2026-05-20  6:56   ` Damien Le Moal
2026-05-20  7:22   ` Christoph Hellwig
2026-05-20 19:54     ` Chao S
2026-05-19 17:23 ` [PATCH RFC 2/5] block: fix invalid zone append status Keith Busch
2026-05-20  6:58   ` Damien Le Moal
2026-05-20  7:23   ` Christoph Hellwig
2026-05-19 17:23 ` [PATCH RFC 3/5] block: validate bio bounds in the queue entered context Keith Busch
2026-05-20  7:22   ` Damien Le Moal
2026-05-20  7:25     ` Damien Le Moal
2026-08-10 21:12   ` Chris S
2026-08-10 21:23     ` Keith Busch [this message]
2026-05-19 17:23 ` [PATCH RFC 4/5] block: move bio validation into __bio_split_to_limits Keith Busch
2026-05-20  7:25   ` Christoph Hellwig
2026-05-20 15:19     ` Keith Busch
2026-05-19 17:23 ` [PATCH RFC 5/5] block, nvme: add failed_bio callback for multipath bio failover Keith Busch
2026-05-20  7:27   ` Christoph Hellwig
2026-05-20 15:07     ` Keith Busch
2026-05-20 15:26       ` Keith Busch
2026-05-27 14:04         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anpBQXfo7eGNU2-v@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=Igor.Achkinazi@dell.com \
    --cc=axboe@kernel.dk \
    --cc=coshi036@gmail.com \
    --cc=dlemoal@kernel.org \
    --cc=hch@lst.de \
    --cc=kbusch@meta.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=tom.leiming@gmail.com \
    --cc=weizhu@fiu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox